Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 12034: standardize alerts referring to lists and list items

Browse source 
The staff client lists template contains a warning which differs from
the same warning in the OPAC. The OPAC version is correct because it
refers to a list rather than a shelf. This patch copies the OPAC version
to the staff client template.

This patch also corrects a few of other instances where the incorrect
term "shelf" is used.

To test, apply the patch and view a list in the staff client which is
populated with items. Check the box next to one or more items on the
list and click the "Remove selected" button. You should see the message,
"Are you sure you want to remove these items from the list?"

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Work as described, no koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Owen Leonard 2014-04-03 08:38:08 -04:00 committed by Galen Charlton
parent fe205c907a
commit 0f7b89633e
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
View file

@ -9,7 +9,7 @@
//<![CDATA[ //<![CDATA[
var MSG_NO_ITEM_SELECTED = _("Nothing is selected."); var MSG_NO_ITEM_SELECTED = _("Nothing is selected.");
var MSG_REMOVE_FROM_LIST = _("Are you sure you want to remove these records from the shelf?"); var MSG_REMOVE_FROM_LIST = _("Are you sure you want to remove these items from the list?");
var MSG_CONFIRM_DELETE_LIST = _("Are you sure you want to remove this list?"); var MSG_CONFIRM_DELETE_LIST = _("Are you sure you want to remove this list?");
[% IF ( viewshelf ) %] [% IF ( viewshelf ) %]
$(document).ready(function(){ $(document).ready(function(){
@ -230,7 +230,7 @@ function placeHold () {
[% IF ( paramsloo.already ) %]<div class="dialog alert">A List named [% paramsloo.already %] already exists!</div>[% END %] [% IF ( paramsloo.already ) %]<div class="dialog alert">A List named [% paramsloo.already %] already exists!</div>[% END %]
[% IF ( paramsloo.status ) %]<div class="dialog alert">[% paramsloo.string %]</div>[% END %] [% IF ( paramsloo.status ) %]<div class="dialog alert">[% paramsloo.string %]</div>[% END %]
[% IF ( paramsloo.nobarcode ) %]<div class="dialog alert">ERROR: No barcode given.</div>[% END %] [% IF ( paramsloo.nobarcode ) %]<div class="dialog alert">ERROR: No barcode given.</div>[% END %]
[% IF ( paramsloo.noshelfnumber ) %]<div class="dialog alert">ERROR: No shelfnumber given.</div>[% END %] [% IF ( paramsloo.noshelfnumber ) %]<div class="dialog alert">ERROR: No list number given.</div>[% END %]
[% IF ( paramsloo.need_confirm ) %] [% IF ( paramsloo.need_confirm ) %]
<div class="dialog alert">The list <i>[% paramsloo.need_confirm %]</i> is not empty. <div class="dialog alert">The list <i>[% paramsloo.need_confirm %]</i> is not empty.
<br />It has <b>[% paramsloo.count %]</b> entries. <br />It has <b>[% paramsloo.count %]</b> entries.
@ -247,10 +247,10 @@ function placeHold () {
<div class="dialog alert">A record matching barcode <b>[% paramsloo.duplicatebiblio %]</b> has already been added.</div> <div class="dialog alert">A record matching barcode <b>[% paramsloo.duplicatebiblio %]</b> has already been added.</div>
[% END %] [% END %]
[% IF ( paramsloo.nothingdeleted) %] [% IF ( paramsloo.nothingdeleted) %]
<div class="dialog message">Warning: You could not delete any selected items from this shelf.</div> <div class="dialog message">Warning: You could not delete any of the selected items from this list.</div>
[% END %] [% END %]
[% IF ( paramsloo.somedeleted) %] [% IF ( paramsloo.somedeleted) %]
<div class="dialog message">Warning: You could not delete all selected items from this shelf.</div> <div class="dialog message">Warning: You could not delete all selected items from this list.</div>
[% END %] [% END %]
[% IF ( paramsloo.modifyfailure) %] [% IF ( paramsloo.modifyfailure) %]
<div class="dialog message">ERROR: List could not be modified.</div> <div class="dialog message">ERROR: List could not be modified.</div>