Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 16136: Koha::Patron contains 'return undef' and fails critic tests

Browse source 
This patch fixes this issue.

To test:
- Run
  $ TEST_QA=1 prove t/00-testcritic.t
=> FAIL: Koha::Patron makes the tests fail.
- Apply the patch
- Run
  $ TEST_QA=1 prove t/00-testcritic.t
=> SUCCESS: tests PASS
- Sign off

Regards

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
This commit is contained in:
Tomas Cohen Arazi 2016-03-23 14:57:41 -03:00 committed by Brendan A Gallagher
parent 6303016736
commit 0f8792961c
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Koha/Patron.pm
View file

@ -45,7 +45,7 @@ Returns a Koha::Patron object for this patron's guarantor
sub guarantor {
my ( $self ) = @_;
return undef unless $self->guarantorid();
return unless $self->guarantorid();
return Koha::Patrons->find( $self->guarantorid() );
}
@ -79,7 +79,7 @@ sub siblings {
my $guarantor = $self->guarantor;
return undef unless $guarantor;
return unless $guarantor;
return Koha::Patrons->search(
{