Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 37285: Printing lists only prints the ten first results

Browse source 
GIVEN koha in a version later than 22.11, a list with more than ten entries
WHEN the user tries to print the list
THEN only the ten first results are printed

EXPECTED THEN all results are printed

It looks like it is an undesired effect of BZ36858. Page remains set
even while printing, therefore, however the number of rows is not set,
default value (10) is used.

TEST PLAN

1 - create a list with more than 10 items
2 - print the list -> there is a pagination and that only 10 items
  are printed
Apply patch
3 - print the list again -> every items are being printed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 64027daadc)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Baptiste Wojtkowski 2024-07-09 16:08:39 +02:00 committed by Lucas Gass
parent 59d8f236ad
commit 0f8f20a01f
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
virtualshelves/shelves.pl
View file

@ -276,7 +276,9 @@ if ( $op eq 'view' ) {
my $direction = $query->param('direction') || 'asc'; my $direction = $query->param('direction') || 'asc';
$direction = 'asc' if $direction ne 'asc' and $direction ne 'desc'; $direction = 'asc' if $direction ne 'asc' and $direction ne 'desc';
my $rows; my $rows;
unless ( $query->param('print') ) { if ( $query->param('print') ) {
$page="";
} else {
$rows = C4::Context->preference('numSearchResults') || 20; $rows = C4::Context->preference('numSearchResults') || 20;
} }