Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35635: Add missing NOT NULL clause in db rev

Browse source 
Jenkins job testing the update DB was failing:

18:11:48 koha_1       | +++ b/Koha/Schema/Result/BorrowerAttributeType.pm
18:11:48 koha_1       | @@ -141,7 +141,7 @@ defines if this field is copied to anonymized_borrower_attributes (1 for yes, 0
18:11:48 koha_1       |
18:11:48 koha_1       |    data_type: 'tinyint'
18:11:48 koha_1       |    default_value: 0
18:11:48 koha_1       | -  is_nullable: 0
18:11:48 koha_1       | +  is_nullable: 1
18:11:48 koha_1       |
18:11:48 koha_1       |  defines if the attribute is mandatory or not in the staff interface
18:11:48 koha_1       |
18:11:48 koha_1       | @@ -149,7 +149,7 @@ defines if the attribute is mandatory or not in the staff interface
18:11:48 koha_1       |
18:11:48 koha_1       |    data_type: 'tinyint'
18:11:48 koha_1       |    default_value: 0
18:11:48 koha_1       | -  is_nullable: 0
18:11:48 koha_1       | +  is_nullable: 1
18:11:48 koha_1       |
18:11:48 koha_1       |  defines if the attribute is mandatory or not in the OPAC
18:11:48 koha_1       |
18:11:48 koha_1       | @@ -185,9 +185,9 @@ __PACKAGE__->add_columns(
18:11:48 koha_1       |    "keep_for_pseudonymization",
18:11:48 koha_1       |    { data_type => "tinyint", default_value => 0, is_nullable => 0 },
18:11:48 koha_1       |    "mandatory",
18:11:48 koha_1       | -  { data_type => "tinyint", default_value => 0, is_nullable => 0 },
18:11:48 koha_1       | +  { data_type => "tinyint", default_value => 0, is_nullable => 1 },
18:11:48 koha_1       |    "opac_mandatory",
18:11:48 koha_1       | -  { data_type => "tinyint", default_value => 0, is_nullable => 0 },
18:11:49 koha_1       | +  { data_type => "tinyint", default_value => 0, is_nullable => 1 },
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Jonathan Druart 2025-03-11 14:22:16 +01:00 committed by Katrin Fischer
parent b63388351b
commit 0fb5bc3e04
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
installer/data/mysql/db_revs/241200010.pl
View file

@ -13,7 +13,7 @@ return {
$dbh->do( $dbh->do(
q{ q{
ALTER TABLE borrower_attribute_types ALTER TABLE borrower_attribute_types
MODIFY COLUMN `mandatory` tinyint(1) DEFAULT 0 COMMENT 'defines if the attribute is mandatory or not in the staff interface' MODIFY COLUMN `mandatory` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines if the attribute is mandatory or not in the staff interface'
} }
); );
say_success( $out, "Modified column 'borrower_attribute_types.mandatory'" ); say_success( $out, "Modified column 'borrower_attribute_types.mandatory'" );
@ -21,7 +21,7 @@ return {
$dbh->do( $dbh->do(
q{ q{
ALTER TABLE borrower_attribute_types ALTER TABLE borrower_attribute_types
ADD COLUMN `opac_mandatory` tinyint(1) DEFAULT 0 COMMENT 'defines if the attribute is mandatory or not in the OPAC' ADD COLUMN `opac_mandatory` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines if the attribute is mandatory or not in the OPAC'
AFTER `mandatory` AFTER `mandatory`
} }
); );