Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 36520: Prevent SQL injection in GetPreparedLetter

Browse source 
Actually in _get_tt_params

The following query will delay the response

SELECT `me`.`biblionumber`, `me`.`frameworkcode`, `me`.`author`, `me`.`title`, `me`.`medium`, `me`.`subtitle`, `me`.`part_number`, `me`.`part_name`, `me`.`unititle`, `me`.`notes`, `me`.`serial`, `me`.`seriestitle`
, `me`.`copyrightdate`, `me`.`timestamp`, `me`.`datecreated`, `me`.`abstract`
  FROM `biblio` `me`
WHERE `biblionumber` = '1) AND (SELECT 1 FROM (SELECT(SLEEP(6)))x)-- -'
ORDER BY field( biblionumber, 1 ) AND (
    SELECT 1
      FROM
    SELECT SLEEP( 6 ) x
   ) -- - )

To test
1/ Add some items to your cart in the opac
2/ Choose send cart
3/ Open firefox developer tools and switch to the network tab
4/ Send cart
5/ In the network tab, find the post request and choose copy as curl
6/ Edit the curl command to add )+AND+(SELECT+1+FROM+(SELECT(SLEEP(6)))x)--+-  to the bib_list parameter
7/ Run the curl notice it takes a long time to respond, if you want to check run the curl without the above part added
8/ Apply the patch and restart plack
9/ Run the modified curl and notice no longer the slow down
10/ Test in browser and make sure the basket is still sent

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2024-05-13 14:47:28 +02:00 committed by Lucas Gass
parent 0329182109
commit 10068dd604
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
C4/Letters.pm
View file

@ -1818,6 +1818,7 @@ sub _get_tt_params {
}
};
my $dbh = C4::Context->dbh;
foreach my $table ( keys %$tables ) {
next unless $config->{$table};
@ -1838,12 +1839,19 @@ sub _get_tt_params {
my $objects = $module->search(
{ $key => $values },
{
# We want to retrieve the data in the same order
# FIXME MySQLism
# field is a MySQLism, but they are no other way to do it
# To be generic we could do it in perl, but we will need to fetch
# all the data then order them
@$values ? ( order_by => \[ "field($key, " . join( ', ', @$values ) . ")" ] ) : ()
# We want to retrieve the data in the same order
# FIXME MySQLism
# field is a MySQLism, but they are no other way to do it
# To be generic we could do it in perl, but we will need to fetch
# all the data then order them
@$values
? (
order_by => \[
sprintf "field(%s, %s)", $key,
join(',', map { $dbh->quote($_) } @$values )
]
)
: ()
}
);
$params->{ $config->{$table}->{plural} } = $objects;