Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35053: Regression tests

Browse source 
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 683b74d202)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 6de7575cae)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Tomás Cohen Arazi 2023-10-17 09:03:33 -03:00 committed by Matt Blenkinsop
parent f3742afa64
commit 1058c877e4
1 changed files with 24 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
t/db_dependent/api/v1/holds.t
View file

@ -1097,7 +1097,7 @@ subtest 'edit() tests' => sub {
subtest 'add() tests' => sub {
plan tests => 21;
plan tests => 24;
$schema->storage->txn_begin;
@ -1139,17 +1139,22 @@ subtest 'add() tests' => sub {
return Koha::Libraries->search( { branchcode => [ $library_2->branchcode, $library_3->branchcode ] } );
});
my $can_be_reserved = 'OK';
my $can_biblio_be_reserved = 'OK';
my $can_item_be_reserved = 'OK';
my $mock_reserves = Test::MockModule->new('C4::Reserves');
$mock_reserves->mock( 'CanItemBeReserved', sub
{
return { status => $can_be_reserved }
$mock_reserves->mock(
'CanItemBeReserved',
sub {
return { status => $can_item_be_reserved };
}
);
$mock_reserves->mock( 'CanBookBeReserved', sub
{
return { status => $can_be_reserved }
$mock_reserves->mock(
'CanBookBeReserved',
sub {
return { status => $can_biblio_be_reserved };
}
);
@ -1243,7 +1248,18 @@ subtest 'add() tests' => sub {
->status_is(400)
->json_is({ error => 'The supplied pickup location is not valid' });
$can_item_be_reserved = 'notReservable';
$can_biblio_be_reserved = 'OK';
$item_hold_data->{pickup_library_id} = $library_2->branchcode;
$t->post_ok( "//$userid:$password@/api/v1/holds" => json => $item_hold_data )
->status_is(403, 'Item checks performed when both biblio_id and item_id passed (Bug 35053)')
->json_is({ error => 'Hold cannot be placed. Reason: notReservable' });
$can_item_be_reserved = 'OK';
$can_biblio_be_reserved = 'OK';
$t->post_ok( "//$userid:$password@/api/v1/holds" => json => $item_hold_data )
->status_is(201);