Bug 3142: (QA follow-up) Cosmetic changes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Marcel de Rooy 2021-10-08 08:31:52 +00:00 committed by Jonathan Druart
parent 064500bc96
commit 10b971c08b

View file

@ -43,9 +43,9 @@ Koha::Items - Koha Item object set class
my $filtered_items = $items->filter_by_for_hold; my $filtered_items = $items->filter_by_for_hold;
Return the items of the set that are *potentially* holdable Return the items of the set that are *potentially* holdable.
Caller has the responsability to call C4::Reserves::CanItemBeReserved before Caller has the responsibility to call C4::Reserves::CanItemBeReserved before
placing a hold on one of those items. placing a hold on one of those items.
=cut =cut
@ -66,9 +66,8 @@ sub filter_by_for_hold {
{ {
itemlost => 0, itemlost => 0,
withdrawn => 0, withdrawn => 0,
notforloan => { '<=' => 0 } notforloan => { '<=' => 0 }, # items with negative or zero notforloan value are holdable
, # items with negative or zero notforloan value are holdable ( C4::Context->preference('AllowHoldsOnDamagedItems' ) ? () : ( damaged => 0 ) ),
( ! C4::Context->preference('AllowHoldsOnDamagedItems' ) ? ( damaged => 0 ) : () ),
itype => { -not_in => \@hold_not_allowed_itypes }, itype => { -not_in => \@hold_not_allowed_itypes },
} }
); );