From 1162629cf09f1c7bbc3c938f470b24dc90100a6f Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Mon, 21 Aug 2023 16:51:59 +0000
Subject: [PATCH] Bug 34584: Remove Twitter share button from the OPAC

This patch removes the option to share content in the OPAC via Twitter
now that Twitter doesn't exist anymore.

To test, apply the patch and go to Administration -> System preferences.

- Search for "SocialNetworks."
- The menu of options should contain only email, Facebook, and LinkedIn.
- Select all options and save.
- In the OPAC, locate a bibliographic record and view its details.
- In the right-hand sidebar, you should only see options to share via
  email, Facebook, and LinkedIn.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 1 -
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss               | 4 ----
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt       | 2 --
 3 files changed, 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
index 060e76b2de..199a0615e1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ -477,7 +477,6 @@ OPAC:
                 facebook: Facebook
                 linkedin: LinkedIn
                 email: Email
-                twitter: Twitter
 
             - "social network links on the OPAC detail pages."
         -
diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
index 4564d9b344..4e32b1b102 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
@@ -1594,10 +1594,6 @@ nav {
         color: #4267B2;
     }
 
-    #twitter {
-        color: #1DA1F2;
-    }
-
     #linkedin {
         color: #0073B0;
     }
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
index db725b5814..5c0ba2042d 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ -1090,8 +1090,6 @@
                                         <div><a id="linkedin" href="https://www.linkedin.com/shareArticle?mini=true&amp;url=[% current_url |url %]&amp;title=[% title |url %]" title="Share on LinkedIn"><i class="fab fa-linkedin" aria-hidden="true"></i></a></div>
                                     [% CASE "email" -%]
                                         <div><a id="email" href="mailto:?subject=[% title |url %]&amp;body=[% title |url %]%20([% current_url |url %])" title="Share by email"><i class="fa-solid fa-envelope" aria-hidden="true"></i></a></div>
-                                    [% CASE "twitter" -%]
-                                        <div><a id="twitter" href="https://twitter.com/share?url=[% current_url|url %]&text=[% title | uri %]" class="twitter-share-button" data-count="none" data-lang="[% lang | html %]" title="Share on Twitter"><i class="fab fa-twitter" aria-hidden="true"></i></a></div>
                                 [% END # /SWITCH network -%]
                             [% END # /FOREACH network %]
                         </div> <!-- /#social_networks -->