Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 38243: Remove DT's header_filter custom param

Browse source 
It seems to be a leftover from bug 32401, the code does not make sense:

 569                 if(options.header_filter) {
 570                     options.query_parameters = query_parameters;
 571                 } else {
 572                     dataSet.q = query_parameters;
 573                     delete options.query_parameters;
 574                 }

Then options.query_parameters is never used.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Jonathan Druart 2024-10-23 16:49:27 +02:00 committed by Katrin Fischer
parent 6a00625870
commit 130e06266c
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
2 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
View file

@ -1026,7 +1026,6 @@
"ajax": {
"url": pending_orders_url + "?q=" + encodeURI(JSON.stringify(base_query))
},
"header_filter": true,
"embed": [
"invoice",
"basket"

10
koha-tmpl/intranet-tmpl/prog/js/datatables.js
View file

@ -626,15 +626,9 @@ function _dt_default_ajax (params){
if(query_parameters.length) {
query_parameters = JSON.stringify(query_parameters.length === 1?query_parameters[0]:{"-and": query_parameters});
if(options.header_filter) {
options.query_parameters = query_parameters;
} else {
dataSet.q = query_parameters;
delete options.query_parameters;
}
} else {
delete options.query_parameters;
dataSet.q = query_parameters;
}
delete options.query_parameters;
dataSet._match = options.criteria;