Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 28924: (QA follow-up): Remove unnecessary template method

Browse source 
Sponsored-by: Cuyahoga County Public Library <https://cuyahogalibrary.org/>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Matt Blenkinsop 2024-06-14 14:47:07 +00:00 committed by Katrin Fischer
parent 08328a5d3a
commit 132b22bbfa
Signed by: kfischer
GPG key ID: 0EF6E2C03357A834
4 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Koha/Template/Plugin/Categories.pm
View file

@ -45,12 +45,6 @@ sub can_any_reset_password {
: 0;
}
sub GetPatronCharges {
my ( $self, $params ) = @_;
my $charges = Koha::Patron->is_patron_inside_charge_limits({ borrowernumber => $params });
return $charges->{noissuescharge};
}
1;
=head1 NAME

5
koha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc
View file

@ -1,10 +1,9 @@
[% USE Price %]
[% USE Categories %]
[% SET NoIssuesCharge = Categories.GetPatronCharges(borrowernumber) %]
[% IF NoIssuesCharge.charge and NoIssuesCharge.charge > 0 %]
[% IF NoIssuesCharge and NoIssuesCharge > 0 %]
<li>
<span class="circ-hlt">Charges:</span>
<span>Patron has outstanding charges of [% NoIssuesCharge.charge | $Price %].</span>
<span>Patron has outstanding charges of [% NoIssuesCharge | $Price %].</span>
[% IF !Koha.Preference('AllowFineOverride') && NoIssuesCharge.limit && NoIssuesCharge.overlimit %]
<span class="circ-hlt">Checkouts are BLOCKED because fine balance is OVER THE LIMIT.</span>
[% END %]

2
koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
View file

@ -119,7 +119,7 @@
[% END %]
[% IF ( charges ) %]
[% INCLUDE 'blocked-fines.inc' borrowernumber = patron.borrowernumber %]
[% INCLUDE 'blocked-fines.inc' NoIssuesCharge = chargesamount %]
[% END %]
[% IF ( charges_guarantors_guarantees ) %]

2
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
View file

@ -63,7 +63,7 @@
<div class="dialog alert">
Cannot check out!
[% IF ( charges ) %]
[% INCLUDE 'blocked-fines.inc' borrowernumber = patron.borrowernumber %]
[% INCLUDE 'blocked-fines.inc' NoIssuesCharge = chargesamount %]
[% END %]
[% IF ( charges_guarantors_guarantees ) %]
<li>