Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18829: (QA follow-up) Replace forbidden indirect syntax

Browse source 
This pattern is forbidden and was overlooked by QA.

To test:
1. Run:
   $ ktd --shell
  k$ prove t/00-testcritic.t
=> FAIL: Tests fail with 'Subroutine "new" called using indirect
syntax...'
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests pass
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Tomás Cohen Arazi 2023-04-17 08:24:12 -03:00
parent d95f31dcc6
commit 1344050ab4
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
catalogue/showelastic.pl
View file

@ -39,7 +39,7 @@ use C4::XSLT ;
use Koha::SearchEngine::Elasticsearch; use Koha::SearchEngine::Elasticsearch;
use LWP::Simple qw/get/; use LWP::Simple qw/get/;
my $input= new CGI; my $input= CGI->new;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user( my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{ {
template_name => "catalogue/showelastic.tt", template_name => "catalogue/showelastic.tt",