Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 19188: Self checkout missing currency symbol

Browse source 
Test plan:
1. Under administration and system preferences, enable WebBasedSelfCheck
2. In OPAC give user fine by going to 'my account' at top right
3. Then under fines tab 'create manual invoice'
4. Make sure this amount is more than noissuescharge which can be
   changed under system preferences
5. Go to the web based self check from the OPAC URL
6. Log in as your user
7. Try to check out an item
7. Error 'Item cannot be checked out' should occur
8. With the patch, the currency symbol should show for the amount.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 5eab08cc2e)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
This commit is contained in:
Jenny Way 2018-01-16 22:05:39 +00:00 committed by Jacob O'Mara
parent 74957821f9
commit 13f7ee3e93
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
View file

@ -1,4 +1,4 @@
[% USE raw %]
[% USE raw %]
[% USE Asset %]
[% USE Koha %]
[% USE KohaDates %]
@ -69,7 +69,7 @@
[% ELSIF ( circ_error_NOT_FOR_LOAN ) %]
<span id="ce_not_for_loan">This item is not for loan.</span>
[% ELSIF ( circ_error_DEBT ) %]
<span id="ce_too_much_debt">You owe the library [% DEBT | $Price %] and cannot check out.</span>
<span id="ce_too_much_debt">You owe the library [% currencySym %] [% DEBT | $Price %] and cannot check out.</span>
[% ELSIF ( circ_error_WTHDRAWN ) %]
<span id="ce_wthdrawn">This item has been withdrawn from the collection.</span>
[% ELSIF ( circ_error_RESTRICTED ) %]

2
opac/sco/sco-main.pl
View file

@ -200,6 +200,7 @@ elsif ( $patron && ( $op eq 'checkout' ) ) {
);
if ($issue_error eq 'DEBT') {
$template->param(DEBT => $impossible->{DEBT});
$template->param(currencySym => $currencySymbol);
}
if ( $issue_error eq "NO_MORE_RENEWALS" ) {
$return_only = 1;
@ -224,6 +225,7 @@ elsif ( $patron && ( $op eq 'checkout' ) ) {
);
if ($issue_error eq 'DEBT') {
$template->param(DEBT => $needconfirm->{DEBT});
$template->param(currencySym => $currencySymbol);
}
} else {
if ( $confirmed || $issuenoconfirm ) { # we'll want to call getpatroninfo again to get updated issues.