From 141223b0fd951038ddf4efebbcb7f3708cc15200 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 2 Aug 2022 06:54:59 +0200
Subject: [PATCH] Bug 29897: Don't display empty li

It's ugly to move the li to the include file, but it's the easiest for
now...

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../en/includes/authority-identifiers.inc     | 30 ++++++++++++-------
 .../bootstrap/en/modules/opac-auth-detail.tt  |  4 +--
 .../bootstrap/en/modules/opac-detail.tt       |  4 +--
 3 files changed, 22 insertions(+), 16 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-identifiers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-identifiers.inc
index 55077ddbb2..85d68c09be 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-identifiers.inc
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/authority-identifiers.inc
@@ -1,17 +1,27 @@
 [% SWITCH identifier.source.lower %]
 [% CASE 'orcid' %]
-    <span>ORCID: </span>
-    <a href="https://orcid.org/[% identifier.number | url %]">[% identifier.number | html %]</a>
+    <li>
+        <span>ORCID: </span>
+        <a href="https://orcid.org/[% identifier.number | url %]">[% identifier.number | html %]</a>
+    </li>
 [% CASE 'scopus' %]
-    <span>ScopusID: </span>
-    <a href="https://www.scopus.com/authid/detail.uri?authorId=[% identifier.number | url %]">[% identifier.number | html %]</a>
+    <li>
+        <span>ScopusID: </span>
+        <a href="https://www.scopus.com/authid/detail.uri?authorId=[% identifier.number | url %]">[% identifier.number | html %]</a>
+    </li>
 [% CASE 'loop' %]
-    <span>loop: </span>
-    <a href="https://loop.frontiersin.org/people/[% identifier.number | url %]">[% identifier.number | html %]</a>
+    <li>
+        <span>loop: </span>
+        <a href="https://loop.frontiersin.org/people/[% identifier.number | url %]">[% identifier.number | html %]</a>
+    </li>
 [% CASE 'rid' %]
-    <span>Publons: </span>
-    <a href="https://publons.com/researcher/[% identifier.number | url %]">[% identifier.number | html %]</a>
+    <li>
+        <span>Publons: </span>
+        <a href="https://publons.com/researcher/[% identifier.number | url %]">[% identifier.number | html %]</a>
+    </li>
 [% CASE 'viaf' %]
-    <span>VIAF: </span>
-    <a href="https://viaf.org/viaf/[% identifier.number | url %]">[% identifier.number | html %]</a>
+    <li>
+        <span>VIAF: </span>
+        <a href="https://viaf.org/viaf/[% identifier.number | url %]">[% identifier.number | html %]</a>
+    </li>
 [% END %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
index 36a53eeda2..a84b103784 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
@@ -186,9 +186,7 @@
                             <span>Identifiers</span>
                             <ul>
                             [% FOR identifier IN author_identifiers %]
-                                <li>
-                                    [% PROCESS "authority-identifiers.inc" identifier => identifier %]
-                                </li>
+                                [% PROCESS "authority-identifiers.inc" identifier => identifier %]
                             [% END %]
                             </ul>
                         </div>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
index 9e41a2be1a..b3607465d8 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ -965,9 +965,7 @@
                                             <span class="author_name"><a href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=[% author.authid | uri %]">[% author.name | html %]</a></span>
                                             <ul>
                                             [% FOR identifier IN author.identifiers %]
-                                                <li>
-                                                    [% PROCESS "authority-identifiers.inc" identifier => identifier %]
-                                                </li>
+                                                [% PROCESS "authority-identifiers.inc" identifier => identifier %]
                                             [% END %]
                                             </ul>
                                         </div>