Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 32519: In Elasticsearch mappings table use of search field name and label

Browse source 
In Elasticsearch mappings table, in tabs for mappings we should add search field name in addition to label ; in order to find them when searching using DataTable search field. This is very useful when debugging.

Also the lines are sorting alphabetically by search field name.
So I propose to display name and label between parenthesis.
And also add label to the form in last line.

By default label equals name so I display label only if different from name.

Test plan :
1) Go to : Administration > Search engine configuration (Elasticsearch)
2) In first tabe edit a line to change label, for example : author => Auteur
3) Save
4) Go to second tab
5) Check you see a line with 'author (Auteur)' and lines with only name when label equals name
6) Look at last line (addition form)
7) Check you see in combobox : 'author (Auteur)' and lines with only name when label equals name

Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Fridolin Somers 2022-12-22 20:15:09 -10:00 committed by Tomas Cohen Arazi
parent b27dd883ca
commit 14a2cc60a4
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
View file

@ -284,7 +284,8 @@ a.add, a.delete {
<td> <td>
<input type="hidden" name="mapping_index_name" value="[% index.index_name | html %]" /> <input type="hidden" name="mapping_index_name" value="[% index.index_name | html %]" />
<input type="hidden" name="mapping_search_field_name" value="[% mapping.search_field_name | html %]"> <input type="hidden" name="mapping_search_field_name" value="[% mapping.search_field_name | html %]">
[% mapping.search_field_label | html %] [% mapping.search_field_name | html %]
[% IF mapping.search_field_label != mapping.search_field_name %] ([% mapping.search_field_label | html %])[% END %]
</td> </td>
<td> <td>
[% IF mapping.sort == 0 %] [% IF mapping.sort == 0 %]
@ -312,7 +313,8 @@ a.add, a.delete {
<td> <td>
<input type="hidden" name="mapping_index_name" value="[% index.index_name | html %]" /> <input type="hidden" name="mapping_index_name" value="[% index.index_name | html %]" />
<input type="hidden" name="mapping_search_field_name" value="[% mapping.search_field_name | html %]"> <input type="hidden" name="mapping_search_field_name" value="[% mapping.search_field_name | html %]">
[% mapping.search_field_label | html %] [% mapping.search_field_name | html %]
[% IF mapping.search_field_label != mapping.search_field_name %] ([% mapping.search_field_label | html %])[% END %]
</td> </td>
<td> <td>
<select name="mapping_sort"> <select name="mapping_sort">
@ -381,7 +383,7 @@ a.add, a.delete {
<input data-id="mapping_index_name" type="hidden" value="[% index.index_name | html %]" /> <input data-id="mapping_index_name" type="hidden" value="[% index.index_name | html %]" />
<select data-id="mapping_search_field_name"> <select data-id="mapping_search_field_name">
[% FOREACH f IN all_search_fields %] [% FOREACH f IN all_search_fields %]
<option value="[% f.name | html %]">[% f.name | html %]</option> <option value="[% f.name | html %]">[% f.name | html %][% IF f.label != f.name %] ([% f.label | html %])[% END %]</option>
[% END %] [% END %]
</select> </select>
</td> </td>