Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 10195: (follow-up) tidying up code and eliminate warning if record does not have 942$n

Browse source 
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This commit is contained in:
Galen Charlton 2014-05-05 15:50:45 +00:00
parent 41b138b783
commit 15a5140f36
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
opac/opac-detail.pl
View file

@ -92,17 +92,20 @@ if ( ! $record ) {
# redirect if opacsuppression is enabled and biblio is suppressed
if (C4::Context->preference('OpacSuppression')) {
# FIXME hardcoded; the suppression flag ought to be materialized
# as a column on biblio or the like
my $opacsuppressionfield = '942';
my $opacsuppressionfieldvalue = $record->field($opacsuppressionfield);
# redirect to opac-blocked info page or 404?
my $opacsuppressionredirect;
if ( C4::Context->preference("OpacSuppressionRedirect") ) {
$opacsuppressionredirect = "/cgi-bin/koha/opac-blocked.pl";
}
else {
} else {
$opacsuppressionredirect = "/cgi-bin/koha/errors/404.pl";
}
if ( $opacsuppressionfieldvalue->subfield("n") == 1) {
if ( $opacsuppressionfieldvalue &&
$opacsuppressionfieldvalue->subfield("n") &&
$opacsuppressionfieldvalue->subfield("n") == 1) {
# if OPAC suppression by IP address
if (C4::Context->preference('OpacSuppressionByIPRange')) {
my $IPAddress = $ENV{'REMOTE_ADDR'};
@ -111,8 +114,7 @@ if (C4::Context->preference('OpacSuppression')) {
print $query->redirect($opacsuppressionredirect);
exit;
}
}
else {
} else {
print $query->redirect($opacsuppressionredirect);
exit;
}