Bug 34724: (QA follow-up):
Replace href from thumbnail link with a # to keep pointer event. The href link gets reconstructed by showCover anyway
Remove return false from on click event, its not triggering a location change anymore because of the above
Remove check for imagenumber, its a non-null primary key, if the image exists, then the imagenumber must also exist
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit bc8a062001
)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
parent
bebd213c87
commit
167f5aa3bb
1 changed files with 2 additions and 6 deletions
|
@ -87,7 +87,7 @@
|
|||
<div class="col-lg-3">
|
||||
<div id="thumbnails">
|
||||
[% FOREACH image IN images %]
|
||||
<a class="cover_thumbnail" data-imagenumber="[% image.imagenumber| html %]" href="/cgi-bin/koha/opac-imageviewer.pl?biblionumber=[% biblionumber | url %]&imagenumber=[% image.imagenumber| uri %]">
|
||||
<a class="cover_thumbnail" data-imagenumber="[% image.imagenumber| html %]" href="#">
|
||||
[% IF loop.first %]
|
||||
<img class="thumbnail selected" id="[% image.imagenumber| html %]" src="/cgi-bin/koha/opac-image.pl?imagenumber=[% image.imagenumber | html %]&thumbnail=1" alt="Thumbnail"/>
|
||||
[% ELSE %]
|
||||
|
@ -114,11 +114,7 @@
|
|||
$("#largeCoverImg").attr("src","[% interface | html %]/[% theme | html %]/images/loading.gif");
|
||||
showCover([% imagenumber | html %]);
|
||||
$("a.cover_thumbnail").on('click',function(){
|
||||
let imagenumber = this.dataset.imagenumber;
|
||||
if (imagenumber){
|
||||
showCover(imagenumber);
|
||||
}
|
||||
return false;
|
||||
showCover(this.dataset.imagenumber);
|
||||
});
|
||||
});
|
||||
|
||||
|
|
Loading…
Reference in a new issue