Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 35890: Remove var loggedin

Browse source 
It is never used and add confusion

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 0ce8cc4c05bc96503172018775ba574e41b40ecb)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Jonathan Druart 2024-01-24 16:24:51 +01:00 committed by Fridolin Somers
parent 104ed9ed0e
commit 16a7ac0fe7
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
C4/Auth.pm
View file

@ -815,7 +815,6 @@ sub checkauth {
_version_check( $type, $query ); _version_check( $type, $query );
# state variables # state variables
my $loggedin = 0;
my $auth_state = 'failed'; my $auth_state = 'failed';
my %info; my %info;
my ( $userid, $cookie, $sessionID, $flags ); my ( $userid, $cookie, $sessionID, $flags );
@ -855,7 +854,6 @@ sub checkauth {
-secure => ( C4::Context->https_enabled() ? 1 : 0 ), -secure => ( C4::Context->https_enabled() ? 1 : 0 ),
-sameSite => 'Lax', -sameSite => 'Lax',
)); ));
$loggedin = 1;
} }
elsif ( $emailaddress) { elsif ( $emailaddress) {
# the Google OpenID Connect passes an email address # the Google OpenID Connect passes an email address
@ -1203,7 +1201,6 @@ sub checkauth {
my $domain = $branches->{$branchcode}->{'branchip'}; my $domain = $branches->{$branchcode}->{'branchip'};
$domain =~ s|\.\*||g; $domain =~ s|\.\*||g;
if ( $ip !~ /^$domain/ ) { if ( $ip !~ /^$domain/ ) {
$loggedin = 0;
$cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie( $cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie(
-name => 'CGISESSID', -name => 'CGISESSID',
-value => '', -value => '',