Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 21027: Fix checkout statistics if 1+ of the fields is not defined

Browse source 
TEST

- Use a patron who hasn't checked out items before
- Set  StatisticsFields to itype|ccode
- Check out some items without location
- Verify that statistics stable shows the correct number of checkouts
- Check out one item with a location or just change one of your checked out items
- Verify the total is still correct
- Change  StatisticsFields to location|itype|ccode
- Verify the total has changed now - it's only 1 (the one with a location)

Apply the patch and try again

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Jonathan Druart 2019-04-28 20:55:02 -04:00 committed by Martin Renvoize
parent f829221f81
commit 17a71b9900
Signed by: martin.renvoize
GPG key ID: 422B469130441A0F
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
members/statistics.pl
View file

@ -198,7 +198,10 @@ sub merge {
for my $ch ( @r ) { for my $ch ( @r ) {
$exists = 1; $exists = 1;
for my $cn ( @statistic_column_names ) { for my $cn ( @statistic_column_names ) {
if ( $ch->{$cn} and not $ch->{$cn} eq $h->{$cn} ) { if ( ( not defined $ch->{$cn} && defined $h->{$cn} )
|| ( defined $ch->{$cn} && not defined $h->{$cn} )
|| ( $ch->{$cn} ne $h->{$cn} ) )
{
$exists = 0; $exists = 0;
last; last;
} }