Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 15416: Warns on guided_reports.pl

Browse source 
Initialising $phase variable to be '' if not defined.

To test:
1) Go to Reports -> Guided Reports Wizard
2) Notice warns
3) Apply patch
4) Refresh page
5) Confirm warns are gone and page still works as it should

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Warns are gone. Page still works as expected

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch:
-my $phase = $input->param('phase');
-$phase //= '';
+my $phase = $input->param('phase') // '';

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
This commit is contained in:
Aleisha 2016-01-18 03:30:44 +00:00 committed by Brendan Gallagher
parent fdd66bc830
commit 17c7c685f1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
reports/guided_reports.pl
View file

@ -47,7 +47,7 @@ Script to control the guided report creation
my $input = new CGI;
my $usecache = C4::Context->ismemcached;
my $phase = $input->param('phase');
my $phase = $input->param('phase') // '';
my $flagsrequired;
if ( $phase eq 'Build new' or $phase eq 'Delete Saved' ) {
$flagsrequired = 'create_reports';