Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18702: Translatability: Get rid of exposed if statement in tt for translated onboardingstep2.tt

Browse source 
The file onboardingstep2.tt exposes the following to translations:

"[%% IF (categories && categories.count > 1 ) # This if statement checks if "
"the categories variable handed to this template # by onboarding.pl has data "
"in it. If the categories variable does have data # in it this means that the "
"user has previously imported sample patron category # data and so we do not "
"need to show them the create patron category screen 1, #instead we can "
"display a screen with ubtton redirecting the user to step 3 %%] "

Translators should not be confronted with such internals. This patch removes it

To test:
- Verify that code change makes sense
- Run QA tools
- Bonus test: Create a new "language" aa-AA and verify that the lines above
  are no longer exposed.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Marc Véron 2017-05-30 18:50:16 +02:00 committed by Jonathan Druart
parent 00d3a883b5
commit 17fd5a4ffb
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt
View file

@ -2,12 +2,12 @@
[% USE KohaDates %] [% USE KohaDates %]
[% INCLUDE 'doc-head-open.inc' %] [% INCLUDE 'doc-head-open.inc' %]
<title>Koha &rsaquo; Web installer &rsaquo; Add a patron category</title> <title>Koha &rsaquo; Web installer &rsaquo; Add a patron category</title>
[% IF (categories && categories.count > 1 ) [%# The following if statement checks if the categories variable handed to this template %]
# This if statement checks if the categories variable handed to this template [%# by onboarding.pl has data in it. If the categories variable does have data %]
# by onboarding.pl has data in it. If the categories variable does have data [%# in it this means that the user has previously imported sample patron category %]
# in it this means that the user has previously imported sample patron category [%# data and so we do not need to show them the create patron category screen 1, %]
# data and so we do not need to show them the create patron category screen 1, [%#instead we can display a screen with ubtton redirecting the user to step 3 %]
#instead we can display a screen with ubtton redirecting the user to step 3 %] [% IF (categories && categories.count > 1 ) %]
<meta http-equiv="refresh" content="0; url=/cgi-bin/koha/installer/onboarding.pl?step=3"> <meta http-equiv="refresh" content="0; url=/cgi-bin/koha/installer/onboarding.pl?step=3">
[% END %] [% END %]
[% INCLUDE 'installer-doc-head-close.inc' %] [% INCLUDE 'installer-doc-head-close.inc' %]