Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34931: Remove fieldset/legend in favor of div/h3

Browse source 
1. Create some PA_CLASS authorized values.
2. Create some custom patron attributes and add them to the newly created PA_CLASS's.
3.  Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'.
4. Go to a new or existing patron record.
5. At the top of the page click the checkbox for "Show collapsed fields:".
6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS.
7. Apply patch
8. Try again, the Additional attributes and identifiers fieldset should display properly.

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Lucas Gass 2023-10-12 22:14:10 +00:00 committed by Tomas Cohen Arazi
parent fac6523b3c
commit 1944c66fc0
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
View file

@ -1554,8 +1554,8 @@ legend:hover {
[% FOREACH pa_loo IN patron_attributes %]
<ol class="attributes_table">
[% IF pa_loo.class %]
<fieldset id="aai_[% pa_loo.class | html %]">
<legend id="[% pa_loo.class | html %]_lgd">[% pa_loo.lib | html %]</legend>
<div id="aai_[% pa_loo.class | html %]">
<h3 id="[% pa_loo.class | html %]_lgd">[% pa_loo.lib | html %]</h3>
[% END %]
[% FOREACH patron_attribute IN pa_loo.items %]
<li data-category_code="[% patron_attribute.category_code | html %]" data-pa_code="[% patron_attribute.code | replace('[^a-zA-Z0-9_-]', '') %]">
@ -1598,7 +1598,7 @@ legend:hover {
[% IF patron_attribute.mandatory %]<span class="required">Required</span>[% END %]
</li>
[% END # /FOREACH patron_attribute %]
[% IF pa_loo.class %]</fieldset>[% END %]
[% IF pa_loo.class %]</div>[% END %]
</ol>
[% END # /FOREACH pa_loo %]
</fieldset> <!-- /#memberentry_patron_attributes -->