Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Added magic RCS string.

Browse source 
Added some FIXME comments.
Removed unused finalizer.
This commit is contained in:
arensb 2002-10-13 06:15:08 +00:00
parent 4779119226
commit 198d27dd88
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
C4/Circulation/Circ2.pm
View file

@ -1,5 +1,7 @@
package C4::Circulation::Circ2; package C4::Circulation::Circ2;
# $Id$
#package to deal with Returns #package to deal with Returns
#written 3/11/99 by olwen@katipo.co.nz #written 3/11/99 by olwen@katipo.co.nz
@ -1105,6 +1107,7 @@ sub fixaccountforlostandreturned {
while (($accdata=$msth->fetchrow_hashref) and ($amountleft>0)){ while (($accdata=$msth->fetchrow_hashref) and ($amountleft>0)){
if ($accdata->{'amountoutstanding'} < $amountleft) { if ($accdata->{'amountoutstanding'} < $amountleft) {
$newamtos = 0; $newamtos = 0;
# FIXME - -=
$amountleft = $amountleft - $accdata->{'amountoutstanding'}; $amountleft = $amountleft - $accdata->{'amountoutstanding'};
} else { } else {
$newamtos = $accdata->{'amountoutstanding'} - $amountleft; $newamtos = $accdata->{'amountoutstanding'} - $amountleft;
@ -1566,6 +1569,7 @@ sub checkaccount {
$sth->execute; $sth->execute;
my $total=0; my $total=0;
while (my $data=$sth->fetchrow_hashref){ while (my $data=$sth->fetchrow_hashref){
# FIXME = +=
$total=$total+$data->{'sum(amountoutstanding)'}; $total=$total+$data->{'sum(amountoutstanding)'};
} }
$sth->finish; $sth->finish;
@ -1580,6 +1584,8 @@ sub checkaccount {
return($total); return($total);
} }
# FIXME - This is identical to &C4::Circulation::Renewals::renewstatus.
# Pick one and stick with it.
sub renewstatus { sub renewstatus {
# Stolen from Renewals.pm # Stolen from Renewals.pm
# check renewal status # check renewal status
@ -1700,6 +1706,8 @@ sub calc_charges {
return ($charge); return ($charge);
} }
# FIXME - A virtually identical function appears in
# C4::Circulation::Issues. Pick one and stick with it.
sub createcharge { sub createcharge {
#Stolen from Issues.pm #Stolen from Issues.pm
my ($env,$dbh,$itemno,$bornum,$charge) = @_; my ($env,$dbh,$itemno,$bornum,$charge) = @_;
@ -1749,6 +1757,8 @@ the fields from the reserves table of the Koha database.
#' #'
# FIXME - This API is bogus: just return the record, or undef if none # FIXME - This API is bogus: just return the record, or undef if none
# was found. # was found.
# FIXME - There's also a &C4::Circulation::Returns::find_reserves, but
# that one looks rather different.
sub find_reserves { sub find_reserves {
# Stolen from Returns.pm # Stolen from Returns.pm
my ($itemno) = @_; my ($itemno) = @_;
@ -1815,8 +1825,6 @@ sub find_reserves {
return ($resfound,$lastrec); return ($resfound,$lastrec);
} }
END { } # module clean-up code here (global destructor)
1; 1;
__END__ __END__