Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34704: Remove regex for adding additional line breaks to print templates

Browse source 
This makes sure that we don't change the line breaking for either
HTML nor plain text print notices.
For plain text, the <pre> is used to keep the line breaks as defined
in the notices template.
For HTML we require on the line breaks added by block elements in the
HTML notice, not adding any additional ones like before.
This gives the full control of the formatting to the notice editor.

To test:
* Make sure your patron doesn't have an email address
* Make sure to check the hold filled notice in messaging preferences
* Place a old on any item
* Checkin the item
* Confirm hold
* Verify notices tab shows the Hold (print) notice
* ./misc/cronjobs/gather_print_notices.pl ./ --html
* Verify the generated file has the HTML output wrapped in pre.
* Reformat the HOLD print notice to be HTML by setting the checkbox.
  Mmake sure to add some empty lines for (they should not print later)
  and some <br>, <p>, <div>  - They should be reflected in the notice later.
* Repeat test.
* All should be well :)

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 4c15ad658d)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit e0eb511d59)
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
This commit is contained in:
Katrin Fischer 2023-11-07 22:31:31 +00:00 committed by Pedro Amorim
parent 50e8b27996
commit 1a04d21a71
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
misc/cronjobs/gather_print_notices.pl
View file

@ -106,14 +106,6 @@ $ods_filenames = print_notices({
}) if $ods;
if ( $html ) {
## carriage return replaced by <br/> as output is html
foreach my $message (@all_messages) {
local $_ = $message->{'content'};
s/\n/<br \/>/g;
s/\r//g;
$message->{'content'} = $_;
}
$html_filenames = print_notices({
messages => \@all_messages,
split => $split,