Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25239: Fix semantic heading for opac-reserve.tt

Browse source 
Prior to this patch, the opac-reserve contained semantically incorrect headings.

Test plan
1/ Perform a search which yields some results in the OPAC
2/ Attempt to place a hold on an item.
3/ On the resulting screen, note that the headings are:
   H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels)
4/ Apply this patch and reload the page
5/ Re-inspect the elements in question note the heading semantics are now:
   H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels)
6/ Note the appearance of the box is still reasonable
7/ Signoff

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Martin Renvoize 2020-06-11 13:05:31 +01:00 committed by Jonathan Druart
parent 6d73c08e73
commit 1a96ede5f1
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
View file

@ -131,7 +131,7 @@
[% UNLESS ( message ) %] [% UNLESS ( message ) %]
[% UNLESS ( none_available ) %] [% UNLESS ( none_available ) %]
<h3>Confirm holds for:[% INCLUDE 'patron-title.inc' patron = logged_in_user %] ([% logged_in_user.cardnumber | html %])</h3> <h2>Confirm holds for:[% INCLUDE 'patron-title.inc' patron = logged_in_user %] ([% logged_in_user.cardnumber | html %])</h2>
[% END # / UNLESS none_available %] [% END # / UNLESS none_available %]
[% IF (RESERVE_CHARGE) %] [% IF (RESERVE_CHARGE) %]
@ -161,7 +161,7 @@
[% IF ( bibitemloo.holdable ) %] [% IF ( bibitemloo.holdable ) %]
<div class="holdrow"> <div class="holdrow">
[% IF bibitemloo.forced_hold_level %] [% IF bibitemloo.forced_hold_level %]
<span class="forced_hold_level"><h5> <span class="forced_hold_level"><h3>
[% IF bibitemloo.forced_hold_level == 'item' %] [% IF bibitemloo.forced_hold_level == 'item' %]
You already have at least one item level hold on this title. You already have at least one item level hold on this title.
All further holds must be item level. All further holds must be item level.
@ -169,7 +169,7 @@
You already have at least one record level hold on this title. You already have at least one record level hold on this title.
All further holds must be record level. All further holds must be record level.
[% END %] [% END %]
</h5></span> </h3></span>
[% END %] [% END %]
<p> <p>
<input class="reserve_mode" name="reserve_mode" type="hidden" value="single"/> <input class="reserve_mode" name="reserve_mode" type="hidden" value="single"/>