Bug 11742: FIX the code parameter was not take into account

In C4::Letters::GetLetters, the code filter was not used as a query
parameter.

Moreover, the JS code was buggy. We only need to check the letter code,
except if it is an edit and the letter code has not been changed.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This commit is contained in:
Jonathan Druart 2014-06-09 12:21:31 +02:00 committed by Tomas Cohen Arazi
parent 5c4fdcf78a
commit 1ac6af8fe2
2 changed files with 10 additions and 4 deletions

View file

@ -85,6 +85,7 @@ sub GetLetters {
. ( $code ? q| AND code = ?| : q|| )
. q| GROUP BY code ORDER BY name|, { Slice => {} }
, ( $module ? $module : () )
, ( $code ? $code : () )
);
return $letters;

View file

@ -59,7 +59,10 @@ $(document).ready(function() {
return false;
}
[% END %]
if ( new_lettercode != '[% code %]' ) {
[% IF ( add_form and code ) # IF edit %]
if ( new_lettercode != '[% code %]' ) {
[% END %]
$.ajax({
data: { code: new_lettercode },
type: 'GET',
@ -73,9 +76,11 @@ $(document).ready(function() {
}
},
});
} else {
$("#add_notice").submit();
}
[% IF ( add_form and code ) %]
} else {
$("#add_notice").submit();
}
[% END %]
});
var sms_limit = 160;