Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 27846: clubs, course_reserves, errors and ill folders

Browse source 
Modified breadcrumbs to be accessible, in particular for a
screen-reader.

Made the block of breadcrumbs be a <nav aria label="Breadcrumb"
class="breadcrumb"> with an ordered list inside. The last breadcrumbs
also has aria-current="page" to specify that it is the current page.

To test:
1) Apply patch
2) Build scss file
3) Ensure each of the files in the clubs, course_reserves, errors and
   ill folders has breadcrumbs that are in a <nav aria
   label="Breadcrumb" class="breadcrumb"> block
4) Ensure that there is an ordered list in the block of breadcrumbs
5) Ensure that the last breadcrumb has aria-current="page"
6) Ensure that the breadcrumbs on each page of the staff client
   belonging to these files look the same as before, but the '>' symbol
   is replaced with '/' and the last breadcrumb has bold text
7) Ensure that when the last breadcrumb is clicked it takes you to the
   page you are currently on

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Wainui Witika-Park 2021-03-08 23:39:38 +00:00 committed by Jonathan Druart
parent e0053d3263
commit 1ae1e6dfe3
14 changed files with 240 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/club-enrollments.tt
View file

@ -12,7 +12,25 @@
<body id="club_enrollments" class="clubs">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> &rsaquo; <a href="clubs.pl">Patron clubs</a> &rsaquo; Club enrollments</div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a>
</li>
<li>
<a href="clubs.pl">Patron clubs</a>
</li>
<li>
<a href="#" aria-current="page">
Club enrollments
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

30
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt
View file

@ -17,13 +17,29 @@
<body id="clubs_add_modify" class="clubs">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> &rsaquo; <a href="clubs.pl">Patron clubs</a> &rsaquo;
[% IF club %]
Modify club <em>[% club.name | html %]</em>
[% ELSE %]
Create a new <em>[% club_template.name | html %]</em> club
[% END %]
</div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a>
</li>
<li>
<a href="clubs.pl">Patron clubs</a>
</li>
<li>
<a href="#" aria-current="page">
[% IF club %]
Modify club <em>[% club.name | html %]</em>
[% ELSE %]
Create a new <em>[% club_template.name | html %]</em> club
[% END %]
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

18
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt
View file

@ -13,7 +13,23 @@
<body id="clubs_clubs" class="clubs">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> &rsaquo; Patron clubs</div>
<div id="breadcrumbs">
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a>
</li>
<li>
<a href="#" aria-current="page">
Patron clubs
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

30
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt
View file

@ -21,13 +21,29 @@
<body id="clubs_templates_add_modify" class="clubs">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> &rsaquo; <a href="clubs.pl">Patron clubs</a> &rsaquo;
[% IF club_template %]
Modify club template <em>[% club_template.name | html %]</em>
[% ELSE %]
Create a new club template
[% END %]
</div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a>
</li>
<li>
<a href="clubs.pl">Patron clubs</a>
</li>
<li>
<a href="#" aria-current="page">
[% IF club_template %]
Modify club template <em>[% club_template.name | html %]</em>
[% ELSE %]
Create a new club template
[% END %]
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

16
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt
View file

@ -7,7 +7,21 @@
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a> &rsaquo; Add reserves for <em><a href="/cgi-bin/koha/course_reserves/course-details.pl?course_id=[% course.course_id | html %]">[% course.course_name | html %]</a></em></div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a>
</li>
<li>
<a href="#" aria-current="page">
Add reserves for <em>[% course.course_name | html %]</em>
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

17
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
View file

@ -10,7 +10,22 @@
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a> &rsaquo;[% IF is_edit || course_reserve %] Edit [% ELSE %] Reserve [% END %]<em><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblio.biblionumber | html %]">[% biblio.title | html %]</a></em> for <em><a href="/cgi-bin/koha/course_reserves/course-details.pl?course_id=[% course.course_id | html %]">[% course.course_name | html %]</a></em></div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a>
</li>
<li>
<a href="#" aria-current="page">
[% IF is_edit || course_reserve %] Edit [% ELSE %] Reserve [% END %]
<em>[% biblio.title | html %]</em> for <em>[% course.course_name | html %]</em>
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

16
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_add_items.tt
View file

@ -13,7 +13,21 @@
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a> &rsaquo; Add reserves for <em><a href="/cgi-bin/koha/course_reserves/course-details.pl?course_id=[% course.course_id | html %]">[% course.course_name | html %]</a></em></div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a>
</li>
<li>
<a href="#" aria-current="page">
Add reserves for <em>[% course.course_name | html %]</em>
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

16
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/batch_rm_items.tt
View file

@ -10,7 +10,21 @@
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a> &rsaquo; Batch remove reserves</div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a>
</li>
<li>
<a href="#" aria-current="page">
Batch remove reserves
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

16
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
View file

@ -24,7 +24,21 @@
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a> &rsaquo; Course details for <em>[% course.course_name | html %]</em></div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a>
</li>
<li>
<a href="#" aria-current="page">
Course details for <em>[% course.course_name | html %]</em>
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

11
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-reserves.tt
View file

@ -14,7 +14,16 @@
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a></div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="#" aria-current="page">Course reserves</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

16
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt
View file

@ -17,7 +17,21 @@
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a> &rsaquo; [% IF course_name %] Edit <em>[% course_name | html %]</em> [% ELSE %] New course [% END %]</div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a>
</li>
<li>
<a href="#" aria-current="page">
[% IF course_name %] Edit <em>[% course_name | html %]</em> [% ELSE %] New course [% END %]
</a>
</li>
</ol>
</nav>
[% IF ( departments ) %]

13
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/invalid-course.tt
View file

@ -6,7 +6,18 @@
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/course_reserves/course-reserves.pl">Course reserves</a></div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="#" aria-current="page">
Course reserves
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

13
koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt
View file

@ -7,7 +7,18 @@
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; Error [% errno | html %]</div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="#" aria-current="page">
Error [% errno | html %]
</a>
</li>
</ol>
</nav>
<div class="main container-fluid">
<div class="row">

42
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
View file

@ -17,15 +17,39 @@
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs">
<a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo;
<a href="/cgi-bin/koha/ill/ill-requests.pl">ILL requests</a>
[% IF query_type == 'create' %]
&rsaquo; New request
[% ELSIF query_type == 'status' %]
&rsaquo; Status
[% END %]
</div>
<nav aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo;
</li>
[% IF query_type == 'create' %]
<li>
<a href="/cgi-bin/koha/ill/ill-requests.pl">ILL requests</a>
</li>
<li>
<a href="#" aria-current="page">
New request
</a>
</li>
[% ELSIF query_type == 'status' %]
<li>
<a href="/cgi-bin/koha/ill/ill-requests.pl">ILL requests</a>
</li>
<li>
<a href="#" aria-current="page">
Status
</a>
</li>
[% ELSE %]
<li>
<a href="#" aria-current="page">
ILL requests
</a>
</li>
[% END %]
</ol>
</nav>
<div class="main container-fluid">
<div class="row">