Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 12937: Deleting suggestions should ask for a confirmation

Browse source 
On the suggestion management page, the librarian can choose to delete
suggestions but no confirmation is needed.
This could produce unexpected lost of data.

Test plan:
- go on the suggestion management page
- don't select any suggestion and try to delete (check the checkbox and submit the form).
  Verify that you get an alert.
- select 1 suggestion and delete it, verify you get a confirmation
  message
- select 1+ suggestions and delete it, verify you get a confirmation
  message

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Jonathan Druart 2014-09-17 13:11:00 +02:00 committed by Tomas Cohen Arazi
parent 171b4e24b3
commit 1b5c0966bb
1 changed files with 25 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
View file

@ -134,6 +134,30 @@ $(document).ready(function() {
datesAD.not( this ).datepicker( "option", option, date );
}
});
$("form.update_suggestions").on("submit", function(e){
var form = this;
var action_delete_selected = $(this).find("input[value='delete']").is(":checked");
if ( action_delete_selected ) {
var suggestions_to_delete = $(this).find("input[name='edit_field']:checked");
if ( suggestions_to_delete.length == 0 ) {
alert(_("No suggestion to delete"));
e.preventDefault();
return false;
} else if ( suggestions_to_delete.length == 1 ) {
if ( ! confirm(_("Are you sure you want to delete this suggestion")) ) {
e.preventDefault();
return false;
}
} else if ( suggestions_to_delete.length > 1 ) {
if ( ! confirm(_("Are you sure you want to delete these suggestions")) ) {
e.preventDefault();
return false;
}
}
}
return true;
});
});
// ]]>
</script>
@ -460,7 +484,7 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o
[% FOREACH suggestion IN suggestions %]
<div id="[% suggestion.suggestiontype %]">
<form name="f[% suggestion.suggestiontype %]" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#[% suggestion.suggestiontype %]">
<form class="update_suggestions" name="f[% suggestion.suggestiontype %]" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#[% suggestion.suggestiontype %]">
[% IF ( suggestion.suggestions_loop ) %]
<p><a id="CheckAll[% suggestion.suggestiontype %]" href="#">Check all</a> | <a id="UncheckAll[% suggestion.suggestiontype %]" href="#">Uncheck all</a></p>