Browse Source

Bug 31160: Required fields in patron api

The Patron API PUT request required the fields "surname","address","city","library_id","category_id". Meanwhile the CSV import page for patrons only requires "surname","library_id","category_id". The fields for "address" and "city" have been removed from the "required" section of the api>v1>swagger>definitions>patron.yaml file to match the CSV import page.

Test Plan:
1) Send a PUT request to http://localhost:8081/api/v1/patrons/19 with an empty body
2) Error message should ask for 5 missing fields as listed above
3) Apply patch
4) Restart Apache server using "restart_all" in your ktd shell
5) Resubmit your request
6) Error message should now only request "surname","library_id","category_id"

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
master
Matt Blenkinsop 2 months ago
committed by Tomas Cohen Arazi
parent
commit
1d522cc246
Signed by: tomascohen GPG Key ID: 0A272EA1B2F3C15F
  1. 2
      api/v1/swagger/definitions/patron.yaml

2
api/v1/swagger/definitions/patron.yaml

@ -377,7 +377,5 @@ properties:
additionalProperties: false
required:
- surname
- address
- city
- library_id
- category_id

Loading…
Cancel
Save