Bug 24072: Typos in advance_notices.pl causes DUEDGST not to be sent
There are two typos in advance_notics.pl that cause DUEDGST messages not to be sent. See Bugzilla for full details. If you think the typo is sufficiently obvious, you can just eyeball the patch and sign off, methinks. Otherwise, testing can be done something like this: - Make sure you have enabled enhanced messaging preferences, and a patron with "Email" and "Digests only" set for "Item due" messages - Issue an item to this patron, with due date today - Run something like this to generate advance notices: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/advance_notices.pl -n -c" kohadev - See that no notices are shown (-n means messages will go to stdout, instead of into the message queue). - Apply the patch and run advance_notices.pl again, as before. A DUEDGST message should now be displayed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
parent
8606ca9a0e
commit
1f3a9722e4
1 changed files with 2 additions and 2 deletions
|
@ -390,7 +390,7 @@ if ($digest_per_branch) {
|
|||
while (my ($branchcode, $digests) = each %$due_digest) {
|
||||
send_digests({
|
||||
sth => $sth_digest,
|
||||
digest => $due_digest,
|
||||
digests => $due_digest,
|
||||
letter_code => 'DUEDGST',
|
||||
branchcode => $branchcode,
|
||||
get_item_info => sub {
|
||||
|
@ -419,7 +419,7 @@ if ($digest_per_branch) {
|
|||
|
||||
send_digests({
|
||||
sth => $sth_digest,
|
||||
digest => $due_digest,
|
||||
digests => $due_digest,
|
||||
letter_code => 'DUEDGST',
|
||||
get_item_info => sub {
|
||||
my $params = shift;
|
||||
|
|
Loading…
Reference in a new issue