Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 18367 - Fix untranslatable string from Bug 18264

Browse source 
Restore display of message when no barcode found

To test:
1 - Go to course reserves
2 - Add an item to a course
3 - Try adding an invalid barcode - should get an alert
4 - Try force adding an item with itemnumber:
    http://localhost:8081/cgi-bin/koha/course_reserves/add_items.pl?op=lookpup&course_id=11&itemnumber=1234523546
5 - Should recieve an error

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2017-04-11 16:09:27 -04:00 committed by Jonathan Druart
parent c1485ae8ce
commit 1fc3751804
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
course_reserves/add_items.pl
View file

@ -55,9 +55,11 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
flagsrequired => { coursereserves => 'add_reserves' },
}
);
my $inumber = $itemnumber ? "(blank) (itemnumber:$itemnumber)" : "";
$template->param( ERROR_BARCODE_NOT_FOUND => $barcode . $inumber )
unless ( $barcode && !$itemnumber && $item && $action eq 'lookup' );
unless ( $item && $action eq 'lookup' ){
$template->param( ERROR_ITEM_NOT_FOUND => 1 );
$template->param( UNKNOWN_BARCODE => $barcode ) if $barcode;
}
$template->param( course => GetCourse($course_id) );

9
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt
View file

@ -11,8 +11,13 @@
<div id="doc" class="yui-t7">
<div id="bd">
[% IF ERROR_BARCODE_NOT_FOUND %]
<div class="dialog alert">No item found with barcode [% ERROR_BARCODE_NOT_FOUND %]</div>
[% IF ERROR_ITEM_NOT_FOUND %]
[% IF UNKNOWN_BARCODE %]
<div class="dialog alert">No item found with barcode [% UNKNOWN_BARCODE %]</div>
[% ELSE %]
<div class="dialog alert">No item found</div>
[% END %]
[% END %]
<form method="post" action="/cgi-bin/koha/course_reserves/add_items.pl">