Browse Source

Bug 31086: Update existing unit tests

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit bf2a9b5279)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
22.05.x
Nick Clemens 2 years ago
committed by Lucas Gass
parent
commit
20226a8082
  1. 8
      t/db_dependent/Holds.t
  2. 4
      t/db_dependent/Reserves.t

8
t/db_dependent/Holds.t

@ -155,6 +155,7 @@ is( $hold->suspend_until, '2013-01-01 00:00:00', "Test ModReserve, suspend until
ModReserve({ # call without reserve_id
rank => '3',
branchcode => $branch_1,
biblionumber => $biblio->biblionumber,
itemnumber => $itemnumber,
borrowernumber => $borrowernumber,
@ -348,6 +349,7 @@ $hold = Koha::Hold->new(
borrowernumber => $borrowernumbers[0],
itemnumber => $itemnumber,
biblionumber => $biblio->biblionumber,
branchcode => $branch_1,
}
)->store();
is( CanItemBeReserved( $patrons[0], $damaged_item )->{status},
@ -527,7 +529,7 @@ subtest 'CanItemBeReserved' => sub {
# Biblio-level hold
AddReserve({
branch => $branch_1,
branchcode => $branch_1,
borrowernumber => $borrowernumbers[0],
biblionumber => $biblionumber_1,
});
@ -543,7 +545,7 @@ subtest 'CanItemBeReserved' => sub {
Koha::Holds->search({borrowernumber => $borrowernumbers[0]})->delete;
# Item-level hold
AddReserve({
branch => $branch_1,
branchcode => $branch_1,
borrowernumber => $borrowernumbers[0],
biblionumber => $biblionumber_1,
itemnumber => $item_11->itemnumber,
@ -597,7 +599,7 @@ subtest 'CanItemBeReserved' => sub {
);
AddReserve({
branch => $branch_1,
branchcode => $branch_1,
borrowernumber => $borrowernumbers[0],
biblionumber => $biblionumber_2,
itemnumber => $item_21->itemnumber

4
t/db_dependent/Reserves.t

@ -559,14 +559,14 @@ my $borrowernumber_tmp_2 = $bor_tmp_2->borrowernumber;
my $date_in_future = dt_from_string();
$date_in_future = $date_in_future->add_duration(DateTime::Duration->new(days => 1));
AddReserve({
branch => 'CPL',
branchcode => 'CPL',
borrowernumber => $borrowernumber_tmp_1,
biblionumber => $bibnum,
priority => 3,
reservation_date => output_pref($date_in_future)
});
AddReserve({
branch => 'CPL',
branchcode => 'CPL',
borrowernumber => $borrowernumber_tmp_2,
biblionumber => $bibnum,
priority => 4,

Loading…
Cancel
Save