Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33880: Remove Version param from GB::Barcode->new

Browse source 
Looking at the code here
     if (Koha/Auth/TwoFactorAuth.pmoSelf->{Version}){        #--- auto version select
        for(->{Version}=1; ->{Version} <= 40; ++->{Version}) {
            last if ({->{Ecc}}->[->{Version}]
                        >=  + ->[->{Version}]);
        }
   }

in https://metacpan.org/release/KWITKNR/GD-Barcode-1.15/source/Barcode/QRcode.pm#L349

It appears the version parameter is not required, and will default to whatever version has the necessary bits for the input words given

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Jake Deery 2023-06-02 13:13:47 +00:00 committed by Tomas Cohen Arazi
parent 7eafb103b5
commit 20d2236681
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/Auth/TwoFactorAuth.pm
View file

@ -101,7 +101,7 @@ sub qr_code {
my $otpauth = $self->SUPER::qr_code( undef, undef, undef, 1);
# no need to pass secret, key and issuer again
my $qrcode = GD::Barcode->new( 'QRcode', $otpauth, { Ecc => 'M', Version => 10, ModuleSize => 4 } );
my $qrcode = GD::Barcode->new( 'QRcode', $otpauth, { Ecc => 'M', ModuleSize => 4 } );
my $data = $qrcode->plot->png;
return "data:image/png;base64,". encode_base64( $data, q{} ); # does not contain newlines
}