From 20e0c056c6faed4252e1718f97f36d15027e93fc Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Tue, 4 Jun 2024 13:00:05 +0300 Subject: [PATCH] Bug 37021: Change item_id type as integer in holds endpoint When one makes a GET call to holds endpoint and hold has item attached to it, item_id is handled as string not integer as it should. To reproduce: 1. Make sure you have hold waiting in your database. 2. Call endpoint api/v1/holds/?q=[{"me.status":"W"}]. => Note that holds item_id is displayed as item_id: "12345". 3. Apply this patch. 4. Call endpoint again. => item_id should now be displayed as 12345. Also prove t/db_dependent/api/v1/holds.t. Signed-off-by: Jan Kissig Signed-off-by: Matt Blenkinsop Signed-off-by: Martin Renvoize --- api/v1/swagger/definitions/hold.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/v1/swagger/definitions/hold.yaml b/api/v1/swagger/definitions/hold.yaml index ae2c055a30..85bcd66900 100644 --- a/api/v1/swagger/definitions/hold.yaml +++ b/api/v1/swagger/definitions/hold.yaml @@ -64,7 +64,7 @@ properties: description: Timestamp for the latest hold update item_id: type: - - string + - integer - "null" description: Internal item identifier waiting_date: