Bug 15343 [QA Follow up] Fix captcha display

Make captcha visible even if password field is hidden
Remove password confirmation field before submitting modification

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt

@@ -814,7 +814,9 @@
                             </ol>
                         [% END %]
                     </fieldset>
+               [% END %]
 
+               [% UNLESS action == 'edit' %]
                     <fieldset class="rows" id="memberentry_captcha">
                         <ol>
 

opac/opac-memberentry.pl

@@ -80,6 +80,7 @@ if ( $action eq 'create' ) {
 
     my @empty_mandatory_fields = CheckMandatoryFields( \%borrower, $action );
     my $invalidformfields = CheckForInvalidFields(\%borrower);
+    delete $borrower{'password2'};
 
     if (@empty_mandatory_fields || @$invalidformfields) {
         $template->param(