Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 20311: Prevent get_age tests to fail on Feb 28th

Browse source 
Today Feb 28th 2018:
If we subtract 18y to this DateTime object 29/02/2000 and so the patron is not major yet

use Koha::DateUtils qw( dt_from_string );
say dt_from_string('28/02/2018')->add(years => -18);
say dt_from_string('28/02/2018')->add(years => -18, end_of_month => 'limit');

will display:
2000-02-29T00:00:00
2000-02-28T00:00:00

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2018-02-28 13:54:32 -03:00
parent f1c75f7bb5
commit 2201fda6c7
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
t/db_dependent/Koha/Patrons.t
View file

@ -528,17 +528,17 @@ subtest 'get_age' => sub {
$patron->dateofbirth( undef );
is( $patron->get_age, undef, 'get_age should return undef if no dateofbirth is defined' );
$patron->dateofbirth( $today->clone->add( years => -12, months => -6, days => -1 ) );
$patron->dateofbirth( $today->clone->add( years => -12, months => -6, days => -1, end_of_month => 'limit' ) );
is( $patron->get_age, 12, 'Patron should be 12' );
$patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 1 ) );
$patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 1, end_of_month => 'limit' ) );
is( $patron->get_age, 17, 'Patron should be 17, happy birthday tomorrow!' );
$patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 0 ) );
$patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 0, end_of_month => 'limit' ) );
is( $patron->get_age, 18, 'Patron should be 18' );
$patron->dateofbirth( $today->clone->add( years => -18, months => -12, days => -31 ) );
$patron->dateofbirth( $today->clone->add( years => -18, months => -12, days => -31, end_of_month => 'limit' ) );
is( $patron->get_age, 19, 'Patron should be 19' );
$patron->dateofbirth( $today->clone->add( years => -18, months => -12, days => -30 ) );
$patron->dateofbirth( $today->clone->add( years => -18, months => -12, days => -30, end_of_month => 'limit' ) );
is( $patron->get_age, 19, 'Patron should be 19 again' );
$patron->dateofbirth( $today->clone->add( years => 0, months => -1, days => -1 ) );
$patron->dateofbirth( $today->clone->add( years => 0, months => -1, days => -1, end_of_month => 'limit' ) );
is( $patron->get_age, 0, 'Patron is a newborn child' );
$patron->delete;