Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 25570: Regression tests

Browse source 
This tests verify that the default behaviour is to paginate the results.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t
=> FAIL: $c->objects->search doesn't paginate results by default

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Tomás Cohen Arazi 2020-05-21 17:48:21 -03:00 committed by Jonathan Druart
parent c0f6f3c635
commit 2220ce4d50
1 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
t/db_dependent/Koha/REST/Plugin/Objects.t
View file

@ -80,6 +80,7 @@ get '/biblios' => sub {
use Test::More tests => 10;
use Test::Mojo;
use t::lib::Mocks;
use t::lib::TestBuilder;
use Koha::Database;
@ -90,7 +91,7 @@ my $builder = t::lib::TestBuilder->new;
subtest 'objects.search helper' => sub {
plan tests => 38;
plan tests => 44;
$schema->storage->txn_begin;
@ -172,6 +173,25 @@ subtest 'objects.search helper' => sub {
->json_is('/2/name' => 'Manuelab')
->json_is('/3/name' => 'Emanuel');
# Add 20 more cities
for ( 1..20 ) {
$builder->build_object({ class => 'Koha::Cities' });
}
t::lib::Mocks::mock_preference('RESTdefaultPageSize', 20 );
$t->get_ok('/cities')
->status_is(200);
my $response_count = scalar @{ $t->tx->res->json };
is( $response_count, 20, 'RESTdefaultPageSize is honoured by default (20)' );
t::lib::Mocks::mock_preference('RESTdefaultPageSize', 5 );
$t->get_ok('/cities')
->status_is(200);
$response_count = scalar @{ $t->tx->res->json };
is( $response_count, 5, 'RESTdefaultPageSize is honoured by default (5)' );
$schema->storage->txn_rollback;
};