Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 34333: Add Koha::Hold->cancellation_requested

Browse source 
This patch adds a helper method for telling if a hold has cancellation
requests. To be used for embedding such information.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: Tests pass, the new method is covered by tests.
3. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Tomás Cohen Arazi 2023-07-20 20:16:39 -03:00
parent ac7581e90a
commit 23cfdf97e3
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
Koha/Hold.pm
View file

@ -645,6 +645,20 @@ sub cancellation_requests {
return Koha::Hold::CancellationRequests->search( { hold_id => $self->id } );
}
=head3 cancellation_requested
if ( $hold->cancellation_requested ) { ... }
Returns true if a cancellation request has been placed for the hold.
=cut
sub cancellation_requested {
my ($self) = @_;
return Koha::Hold::CancellationRequests->search( { hold_id => $self->id } )->count > 0;
}
=head3 cancel
my $cancel_hold = $hold->cancel(

6
t/db_dependent/Koha/Hold.t
View file

@ -728,9 +728,9 @@ subtest 'suspend_hold() and resume() tests' => sub {
$schema->storage->txn_rollback;
};
subtest 'cancellation_requests() and add_cancellation_request() tests' => sub {
subtest 'cancellation_requests(), add_cancellation_request() and cancellation_requested() tests' => sub {
plan tests => 4;
plan tests => 6;
$schema->storage->txn_begin;
@ -739,6 +739,7 @@ subtest 'cancellation_requests() and add_cancellation_request() tests' => sub {
my $hold = $builder->build_object( { class => 'Koha::Holds', } );
is( $hold->cancellation_requests->count, 0 );
ok( !$hold->cancellation_requested );
# Add two cancellation requests
my $request_1 = $hold->add_cancellation_request;
@ -756,6 +757,7 @@ subtest 'cancellation_requests() and add_cancellation_request() tests' => sub {
is( $request_2->creation_date, $creation_date, 'Passed creation_date set' );
is( $hold->cancellation_requests->count, 2 );
ok( $hold->cancellation_requested );
$schema->storage->txn_rollback;
};