Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8

Browse source 
This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Tools home page
    - Log viewer
      - Search result
    - Uploads
      - Upload results
- Cataloging ->
  - Upload local cover image
    - Upload result
    - Test uploading an biblio-level image from the bibliographic detail
      page
    - Test uploading an item-level image from the bibliograhpic detail
      page's holdings table

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Owen Leonard 2023-04-24 11:22:32 +00:00 committed by Tomas Cohen Arazi
parent db488358fe
commit 2553dcef23
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
4 changed files with 70 additions and 108 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
View file

@ -1,3 +1,4 @@
[% USE raw %]
[% USE Koha %]
[% USE Branches %]
[% USE Registers %]
@ -12,19 +13,12 @@
[% END %]
[% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="#" aria-current="page">
Tools
</a>
</li>
</ol>
</nav>
[% END %]
[% WRAPPER breadcrumbs %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Tools</span>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]
<div class="main container-fluid">
<div class="row">

65
koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt
View file

@ -82,59 +82,44 @@
[% END %]
[% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
[% WRAPPER breadcrumbs %]
[% WRAPPER breadcrumb_item %]
<a href="/cgi-bin/koha/cataloguing/cataloging-home.pl">Cataloging</a>
</li>
[% END %]
[% IF uploadimage || biblio || itemnumber || biblionumber %]
<li>
[% WRAPPER breadcrumb_item %]
<a href="/cgi-bin/koha/tools/upload-cover-image.pl">Upload local cover image</a>
</li>
[% END %]
[% END %]
[% IF ( uploadimage ) %]
<li>
<a href="#" aria-current="page">
Upload results
</a>
</li>
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Upload results</span>
[% END %]
[% IF ( biblionumber ) %]
<li>
<a href="#" aria-current="page"><em>[% INCLUDE 'biblio-title.inc' %]</em></a>
</li>
[% WRAPPER breadcrumb_item bc_active= 1 %]
<em>[% INCLUDE 'biblio-title.inc' %]</em>
[% END %]
[% END %]
[% ELSIF biblio %]
<li>
<a href="#" aria-current="page">
Upload cover for <em>[% INCLUDE 'biblio-title.inc' %]</em>
</a>
</li>
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Upload cover for <em>[% INCLUDE 'biblio-title.inc' %]</em></span>
[% END %]
[% ELSIF itemnumber %]
<li>
<a href="#" aria-current="page">
Upload cover for itemnumber: [% itemnumber | html %]
</a>
</li>
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Upload cover for itemnumber: [% itemnumber | html %]</span>
[% END %]
[% ELSIF biblionumber %]
<li>
<a href="#" aria-current="page">
Upload cover for biblionumber: [% biblionumber | html %]
</a>
</li>
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Upload cover for biblionumber: [% biblionumber | html %]</span>
[% END %]
[% ELSE %]
<li>
<a href="#" aria-current="page">
Upload local cover image
</a>
</li>
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Upload local cover image</span>
[% END %]
[% END %]
</ol>
</nav>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]
<div class="main container-fluid">
<div class="row">

52
koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt
View file

@ -21,33 +21,6 @@
[% END %]
[% END %]
[% BLOCK breadcrumbs %]
[% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a>
</li>
<li>
<a href="/cgi-bin/koha/tools/upload.pl">Upload</a>
</li>
<li>
<a href="#" aria-current="page">
[% IF mode=='new' || mode =='deleted'%]
Add new upload or search
[% ELSE %]
Results
[% END %]
</a>
</li>
</ol>
</nav>
[% END %]
[% END %]
[% BLOCK form_new %]
<form method="post" action="/cgi-bin/koha/tools/upload.pl" id="uploadfile" enctype="multipart/form-data">
[% PROCESS plugin_pars %]
@ -268,9 +241,28 @@
<main>
[% ELSE %]
<body id="tools_upload" class="tools">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
[% PROCESS breadcrumbs %]
[% WRAPPER 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
[% END %]
[% WRAPPER 'sub-header.inc' %]
[% WRAPPER breadcrumbs %]
[% WRAPPER breadcrumb_item %]
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a>
[% END %]
[% WRAPPER breadcrumb_item %]
<a href="/cgi-bin/koha/tools/upload.pl">Upload</a>
[% END %]
[% WRAPPER breadcrumb_item %]
<a href="#" aria-current="page">
[% IF mode=='new' || mode =='deleted'%]
<span>Add new upload or search</span>
[% ELSE %]
<span>Results</span>
[% END %]
</a>
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]
<div class="main container-fluid">
<div class="row">

41
koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
View file

@ -168,33 +168,24 @@
[% END %]
[% WRAPPER 'sub-header.inc' %]
<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb">
<ol>
<li>
<a href="/cgi-bin/koha/mainpage.pl">Home</a>
</li>
<li>
[% WRAPPER breadcrumbs %]
[% WRAPPER breadcrumb_item %]
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a>
</li>
[% IF ( do_it ) %]
<li>
<a href="/cgi-bin/koha/tools/viewlog.pl">Logs</a>
</li>
<li>
<a href="#" aria-current="page">
Results
</a>
</li>
[% ELSE %]
<li>
<a href="#" aria-current="page">
Logs
</a>
</li>
[% END %]
</ol>
</nav>
[% END %]
[% IF ( do_it ) %]
[% WRAPPER breadcrumb_item %]
<a href="/cgi-bin/koha/tools/viewlog.pl">Logs</a>
[% END %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Results</span>
[% END %]
[% ELSE %]
[% WRAPPER breadcrumb_item bc_active= 1 %]
<span>Logs</span>
[% END %]
[% END %]
[% END #/ WRAPPER breadcrumbs %]
[% END #/ WRAPPER sub-header.inc %]
<div class="main container-fluid">
<div class="row">