Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

bug 4036: do not count item overdue if it is due today

Browse source 
* use curdate() instead of now() to test whether item is overdue
* enhanced POD of IsMemberBlocked

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This commit is contained in:
Galen Charlton 2010-05-01 11:58:23 -04:00
parent f90995bb96
commit 2568e165e6
1 changed files with 19 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
C4/Members.pm
View file

@ -579,17 +579,26 @@ sub GetMember {
=over 4
my $blocked = IsMemberBlocked( $borrowernumber );
return the status, and the number of day or documents, depends his punishment
return :
-1 if the user have overdue returns
1 if the user is punished X days
0 if the user is authorised to loan
my ($block_status, $count) = IsMemberBlocked( $borrowernumber );
=back
Returns whether a patron has overdue items that may result
in a block or whether the patron has active fine days
that would block circulation privileges.
C<$block_status> can have the following values:
-1 if the patron has overdue items, in which case C<$count> is the number of them
1 if the patron has outstanding fine days, in which case C<$count> is the number of them
0 if the patron has no overdue items or outstanding fine days, in which case C<$count> is 0
FIXME: this needs to be split into two functions; a potential block
based on the number of current overdue items could be orthogonal
to a block based on whether the patron has any fine days accrued.
=cut
sub IsMemberBlocked {
@ -600,7 +609,7 @@ sub IsMemberBlocked {
"SELECT COUNT(*) as latedocs
FROM issues
WHERE borrowernumber = ?
AND date_due < now()"
AND date_due < curdate()"
);
$sth->execute($borrowernumber);
my $latedocs = $sth->fetchrow_hashref->{'latedocs'};
@ -638,7 +647,7 @@ sub IsMemberBlocked {
return (1, $blockedcount) if $blockedcount > 0;
return 0
return (0, 0);
}
=head2 GetMemberIssuesAndFines