Koha-community/Koha
15
7
Fork 0
Code Issues Releases Wiki Activity

Bug 13482: Prevent race condition on printing a ReserveSlip

Browse source 
The problem has been well described by Kyle and Nicole on bug 7255
description and comment 1.

With this counter patch, I suggest to popup AFTER the return has been
confirmed. This will remove the race condition and avoid to pass
itemnumber to the pl file as in the patch submitted by Olli.

Only the borrowernumber and biblionumber are needed (transfer and op are
never used by circ/hold-transfer-slip.pl).

Test plan:
It is very hard to know all cases (at least 6) where the popup is
displayed. Try at least to get the hold and the transfer confirmation
messages.
You should get the popup if you click on "print slip" button.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Jonathan Druart 2015-04-16 14:10:30 +02:00 committed by Tomas Cohen Arazi
parent d1cdbf9d56
commit 2796eb2158
3 changed files with 30 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
circ/hold-transfer-slip.pl
View file

@ -38,7 +38,6 @@ my $session = get_session($sessionID);
my $biblionumber = $input->param('biblionumber');
my $borrowernumber = $input->param('borrowernumber');
my $transfer = $input->param('transfer');
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{

9
circ/returns.pl
View file

@ -68,6 +68,15 @@ if ($session->param('branch') eq 'NO_LIBRARY_SET'){
exit;
}
# Print a reserve slip on this page
if ( $query->param('print_slip') ) {
$template->param(
print_slip => 1,
borrowernumber => $query->param('borrowernumber'),
biblionumber => $query->param('biblionumber'),
);
}
#####################
#Global vars
my $branches = GetBranches();

27
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
View file

@ -18,6 +18,11 @@ function Dopop(link) {
$("#barcode").focus();
}
$(document).ready(function () {
[% IF print_slip %]
Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&amp;biblionumber=[% biblionumber %]');
[% END %]
$("#return_date_override").datetimepicker({
onClose: function(dateText, inst) { $("#barcode").focus(); },
defaultDate: -1,
@ -160,8 +165,11 @@ $(document).ready(function () {
<input type="hidden" name="WT-itemNumber" value="[% WrongTransferItem %]" />
<input type="hidden" name="WT-waitingAt" value="[% TransferWaitingAt %]" />
<input type="hidden" name="WT-From" value="[% wtransfertFrom %]" />
<input type="submit" class="approve" value="Confirm" />
<input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?transfer=1&amp;borrowernumber=[% borrowernumber %]&amp;biblionumber=[% itembiblionumber %]&amp;op=slip'); this.form.submit();" />
<input type="submit" class="approve" value="Confirm" />
<input type="hidden" name="print_slip" value="0" />
<input type="hidden" name="borrowernumber" value="[% borrowernumber %]" />
<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
<input type="submit" value="Print slip and confirm" class="print" onclick="this.form.print_slip.value = 1; this.form.submit();" />
<input type="hidden" name="return_date_override" value="[% return_date_override %]" />
<input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember %]" />
</form>
@ -199,7 +207,8 @@ $(document).ready(function () {
<form method="post" action="returns.pl" class="confirm">
<input type="submit" class="approve" value="Confirm" />
<input type="submit" value="Print and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&amp;biblionumber=[% itembiblionumber %]&amp;op=slip'); this.form.submit();" />
<input type="hidden" name="print_slip" value="0" />
<input type="submit" value="Print and confirm" class="print" onclick="this.form.print_slip.value = 1; this.form.submit();" />
[% FOREACH inputloo IN inputloop %]
<input type="hidden" name="ri-[% inputloo.counter %]" value="[% inputloo.barcode %]" />
<input type="hidden" name="dd-[% inputloo.counter %]" value="[% inputloo.duedate %]" />
@ -207,6 +216,7 @@ $(document).ready(function () {
[% END %]
<input type="hidden" name="itemnumber" value="[% itemnumber %]" />
<input type="hidden" name="borrowernumber" value="[% borrowernumber %]" />
<input type="hidden" name="biblionumber" value="[% itembiblionumber %]" />
<input type="hidden" name="resbarcode" value="[% barcode %]" />
<input type="hidden" name="diffBranch" value="[% destbranch %]" />
<input type="hidden" name="exemptfine" value="[% exemptfine %]" />
@ -244,7 +254,10 @@ $(document).ready(function () {
<form method="post" action="returns.pl" class="confirm">
<input type="submit" class="approve" value="Confirm" />
<input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?transfer=1&amp;borrowernumber=[% borrowernumber %]&amp;biblionumber=[% itembiblionumber %]&amp;op=slip'); this.form.submit();" />
<input type="hidden" name="print_slip" value="0" />
<input type="hidden" name="borrowernumber" value="[% borrowernumber %]" />
<input type="hidden" name="biblionumber" value="[% itembiblionumber %]" />
<input type="submit" value="Print slip and confirm" class="print" onclick="this.form.print_slip.value = 1; this.form.submit();" />
[% FOREACH inputloo IN inputloop %]
<input type="hidden" name="ri-[% inputloo.counter %]" value="[% inputloo.barcode %]" />
<input type="hidden" name="dd-[% inputloo.counter %]" value="[% inputloo.duedate %]" />
@ -359,12 +372,13 @@ $(document).ready(function () {
<h4><strong>Hold at</strong> [% destbranchname %]</h4>
[% END %]
<form method="post" action="returns.pl" class="confirm">
<input type="hidden" name="print_slip" value="0" />
[% IF ( transfertodo ) %]
<input type="submit" class="approve" value="Confirm hold and transfer" />
<input type="submit" value="Print slip, transfer, and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?transfer=1&amp;borrowernumber=[% borrowernumber %]&amp;biblionumber=[% itembiblionumber %]&amp;op=slip'); this.form.submit();" />
<input type="submit" value="Print slip, transfer, and confirm" class="print" onclick="this.form.print_slip.value = 1; this.form.submit()" />
[% ELSE %]
<input type="submit" class="approve" value="Confirm hold" />
<input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&amp;biblionumber=[% itembiblionumber %]&amp;op=slip'); this.form.submit();" />
<input type="submit" value="Print slip and confirm" class="print" onclick="this.form.print_slip.value = 1; this.form.submit();" />
[% END %]
<input type="submit" class="deny" value="Ignore" onclick="$('.dialog:visible').hide('slow'); $('#barcode').focus(); return false;" />
[% FOREACH inputloo IN inputloop %]
@ -373,6 +387,7 @@ $(document).ready(function () {
<input type="hidden" name="bn-[% inputloo.counter %]" value="[% inputloo.borrowernumber %]" />[% END %]
<input type="hidden" name="itemnumber" value="[% itemnumber %]" />
<input type="hidden" name="borrowernumber" value="[% borrowernumber %]" />
<input type="hidden" name="biblionumber" value="[% itembiblionumber %]" />
<input type="hidden" name="resbarcode" value="[% barcode %]" />
<input type="hidden" name="diffBranch" value="[% destbranch %]" />
<input type="hidden" name="exemptfine" value="[% exemptfine %]" />