Bug 32917: Fix sample notice for CHANGE_PASSWORD

We've identified 3 issues:
* Name of patron is not showing up in subject line
* Name of patron is now showing in notice text
* Notice is set to be HTML, but has no line breaks and uses no HTML tags

In the database update, these issues don't occur:

$dbh->do( q{
    INSERT IGNORE INTO letter (module, code, name, title, content, message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of password change', 'Library account password change notification',
    "Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nWe want to notify you that your password has been changed. If you did not change it yourself (or requested that change), please contact library staff.\r\n\r\nYour library.", 'email');
});

So this patch will make them match up:

* Remove HTML flag
* Update patron. to borrower. in message text
* Remove patron name from subject (it won't work even with the correct variables)

To test:
* Add an email address to your favourite sample user
* Make sure NotifyPasswordChange is set to "Notify"
* Update the sample user's password using the "change password" feature
* Verify a notice is shown in the notices tabs
  Note: you won't see the line break issue there because of bug 30287
* Apply patch
* Recreate your database/run web installer so sample notices are loaded
* Repeat the test, it should generate a nice lookig notice now

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Katrin Fischer 2023-04-16 12:19:40 +00:00 committed by Tomas Cohen Arazi
parent 2496f6373a
commit 2873847246
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F

View file

@ -1321,12 +1321,12 @@ tables:
code: PASSWORD_CHANGE
branchcode: ""
name: "Notification of password change"
is_html: 1
title: "Library account password change notification for [% patron.firstname %] [% patron.surname %]"
is_html: 0
title: "Library account password change notification"
message_transport_type: email
lang: default
content:
- "Dear [% patron.firstname %] [% patron.surname %],"
- "Dear [% borrower.firstname %] [% borrower.surname %],"
- ""
- "We want to notify you that your password has been changed. If you did not change it yourself (or requested that change), please contact library staff."
- ""