Bug 29804: Regression tests
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
parent
087176138c
commit
28816cf55b
1 changed files with 47 additions and 1 deletions
|
@ -147,7 +147,7 @@ subtest 'set_pickup_location() tests' => sub {
|
|||
|
||||
subtest 'is_pickup_location_valid() tests' => sub {
|
||||
|
||||
plan tests => 4;
|
||||
plan tests => 5;
|
||||
|
||||
$schema->storage->txn_begin;
|
||||
|
||||
|
@ -200,5 +200,51 @@ subtest 'is_pickup_location_valid() tests' => sub {
|
|||
ok( !$item_hold->is_pickup_location_valid({ library_id => $library_1->branchcode }), 'Pickup location invalid');
|
||||
ok( $item_hold->is_pickup_location_valid({ library_id => $library_2->id }), 'Pickup location valid' );
|
||||
|
||||
subtest 'pickup_locations() returning ->empty' => sub {
|
||||
|
||||
plan tests => 2;
|
||||
|
||||
$schema->storage->txn_begin;
|
||||
|
||||
my $library = $builder->build_object({ class => 'Koha::Libraries' });
|
||||
|
||||
my $mock_item = Test::MockModule->new('Koha::Item');
|
||||
$mock_item->mock( 'pickup_locations', sub { return Koha::Libraries->new->empty; } );
|
||||
|
||||
my $mock_biblio = Test::MockModule->new('Koha::Biblio');
|
||||
$mock_biblio->mock( 'pickup_locations', sub { return Koha::Libraries->new->empty; } );
|
||||
|
||||
my $item = $builder->build_sample_item();
|
||||
my $biblio = $item->biblio;
|
||||
|
||||
# Test biblio-level holds
|
||||
my $biblio_hold = $builder->build_object(
|
||||
{
|
||||
class => "Koha::Holds",
|
||||
value => {
|
||||
biblionumber => $biblio->biblionumber,
|
||||
itemnumber => undef,
|
||||
}
|
||||
}
|
||||
);
|
||||
|
||||
ok( !$biblio_hold->is_pickup_location_valid({ library_id => $library->branchcode }), 'Pickup location invalid');
|
||||
|
||||
# Test item-level holds
|
||||
my $item_hold = $builder->build_object(
|
||||
{
|
||||
class => "Koha::Holds",
|
||||
value => {
|
||||
biblionumber => $biblio->biblionumber,
|
||||
itemnumber => $item->itemnumber,
|
||||
}
|
||||
}
|
||||
);
|
||||
|
||||
ok( !$item_hold->is_pickup_location_valid({ library_id => $library->branchcode }), 'Pickup location invalid');
|
||||
|
||||
$schema->storage->txn_rollback;
|
||||
};
|
||||
|
||||
$schema->storage->txn_rollback;
|
||||
};
|
||||
|
|
Loading…
Reference in a new issue