Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref

Browse source 
C4::Items::GetAnalyticsCount is part of the easy analytics feature.
Like Bug 20702 make early return when the system preference EasyAnalyticalRecords is disabled.
Actually it may block an item deletion for wrong reason.

Test plan :
1) Dont apply patch
2) Build an item and a linked analytical record with 773$0 and $9
3) Enable EasyAnalyticalRecords
4) Try to delete the item
5) You have an alert because linked to analytics
6) Disable EasyAnalyticalRecords
7) Try to delete the item
8) You have an alert because linked to analytics
9) Apply patch
10) Try to delete the item
11) No alert, it works :D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit dfc390940d)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Fridolin Somers 2021-02-11 15:33:35 +01:00 committed by Lucas Gass
parent 555efbd447
commit 28b5880d71
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
C4/Items.pm
View file

@ -1270,6 +1270,10 @@ counts Usage of itemnumber in Analytical bibliorecords.
sub GetAnalyticsCount {
my ($itemnumber) = @_;
if ( !C4::Context->preference('EasyAnalyticalRecords') ) {
return 0;
}
### ZOOM search here
my $query;
$query= "hi=".$itemnumber;