Bug 29389: Add holding branch to the holds queue report

This patch adds the holding branch to the hold queue report.
It is added as hidden by default, when running per branch it is not needed

To test:
 1 - Place some holds in your system
 2 - perl misc/cronjobs/holds/build_holdsqueue.pl
 3 - View the holds queue
 4 - Note there is no 'Current library' column
 5 - Apply patch
 6 - Reload
 7 - Note the column is not there
 8 - Click column setting gear
 9 - Check the column and confirm it appears
10 - Confirm the filter works

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Nick Clemens 2021-11-02 11:57:21 +00:00 committed by Tomas Cohen Arazi
parent 926568a4e2
commit 28d41896dd
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
2 changed files with 10 additions and 0 deletions

View file

@ -1376,6 +1376,9 @@ modules:
columns:
-
columnname: title
-
columnname: holdingbranch
is_hidden: 1
-
columnname: collection
-

View file

@ -77,6 +77,7 @@
<thead>
<tr>
<th class="hq-title anti-the">Title</th>
<th class="hq-holdingbranch">Current library</th>
<th class="hq-collection">Collection</th>
<th class="hq-itemtype">Item type</th>
<th class="hq-callnumber">Call number</th>
@ -95,6 +96,11 @@
<input class="text_filter" type="text" placeholder="Title">
</span>
</td>
<td class="hq-holdingbranch">
<span class="filter_column filter_text">
<input class="text_filter" type="text" placeholder="Current library">
</span>
</td>
<td class="hq-collection">
<span class="filter_column filter_text">
<input type="text" placeholder="Collection">
@ -179,6 +185,7 @@
</div>
</p>
</td>
<td class="hq-holdingbranch">[% Branches.GetName( itemsloo.holdingbranch ) | html %]</td>
<td class="hq-collection">[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => itemsloo.ccode ) | html %]</td>
<td class="hq-itemtype">[% ItemTypes.GetDescription( itemsloo.itype ) | html %]</td>
<td class="hq-callnumber">[% IF ( itemsloo.location ) %]<em>[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => itemsloo.location ) | html %]</em> [% END %][% itemsloo.itemcallnumber | html %]</td>