Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29632: Unit tests

Browse source 
This patch adds unit tests, as well as changing existing test to use a mock
and read the data as passed in tests, rather than relying on what exists in
the DB

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Nick Clemens 2022-07-11 15:56:05 +00:00 committed by Tomas Cohen Arazi
parent b8b8a62f11
commit 295987a061
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 47 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
t/db_dependent/Koha/SearchEngine/Elasticsearch.t
View file

@ -128,14 +128,57 @@ subtest 'get_elasticsearch_settings() tests' => sub {
subtest 'get_elasticsearch_mappings() tests' => sub {
plan tests => 1;
plan tests => 3;
my $mappings;
# test reading mappings
my $es = Koha::SearchEngine::Elasticsearch->new( {index => $Koha::SearchEngine::Elasticsearch::BIBLIOS_INDEX} );
$mappings = $es->get_elasticsearch_mappings();
my @mappings = (
{
name => 'cn-sort',
type => 'callnumber',
facet => 0,
suggestible => 0,
searchable => 1,
sort => 1,
marc_type => 'marc21',
marc_field => '001',
},
{
name => 'isbn',
type => 'string',
facet => 0,
suggestible => 0,
searchable => 1,
sort => 1,
marc_type => 'marc21',
marc_field => '020a',
},
);
my $search_engine_module = Test::MockModule->new('Koha::SearchEngine::Elasticsearch');
$search_engine_module->mock('_foreach_mapping', sub {
my ($self, $sub) = @_;
foreach my $map (@mappings) {
$sub->(
$map->{name},
$map->{type},
$map->{facet},
$map->{suggestible},
$map->{sort},
$map->{searchable},
$map->{marc_type},
$map->{marc_field}
);
}
});
my $search_engine_elasticsearch = Koha::SearchEngine::Elasticsearch::Search->new({ index => $Koha::SearchEngine::Elasticsearch::BIBLIOS_INDEX });
$mappings = $search_engine_elasticsearch->get_elasticsearch_mappings();
is( $mappings->{properties}{"cn-sort__sort"}{index}, 'false', 'Field mappings parsed correctly for sort for callnumber type' );
is( $mappings->{properties}{"cn-sort__sort"}{numeric}, 'false', 'Field mappings parsed correctly for sort for callnumber type' );
is( $mappings->{properties}{isbn__sort}{index}, 'false', 'Field mappings parsed correctly' );
};
subtest 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests' => sub {