Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 31421: Do not apply library limits to Categories plugin

Browse source 
This patch simply changes from using 'search_with_library_limits'
to 'search'

The limits I think are intended to prevent users from setting a patron to the wrong category,
they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search
but cannot be processed. The dropdowns as well won't contain the category, so you can see these
patrons, but not filter by the category

Bug 31422 and bug 31032 point out further issues with limits.

For now, let's fix searching

To test:
1 - Edit Patron category 'Patron/PT'
2 - Try to do a patron search that returns patrons in this category
3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined
4 - Apply patch
5 - Restart all and repeate
6 - It works now!

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Nick Clemens 2022-10-06 19:13:10 +00:00 committed by Tomas Cohen Arazi
parent 4aa8e9bc67
commit 29754226ea
Signed by: tomascohen
GPG key ID: 0A272EA1B2F3C15F
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Koha/Template/Plugin/Categories.pm
View file

@ -25,7 +25,7 @@ use Koha::Patron::Categories;
sub all { sub all {
my ( $self, $params ) = @_; my ( $self, $params ) = @_;
return Koha::Patron::Categories->search_with_library_limits($params); return Koha::Patron::Categories->search($params);
} }
sub GetName { sub GetName {