Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 17748: (follow-up) Stronger unit tests

Browse source 
Before this patch, unit tests perform an item search assuming there is
no checked-out items in database.
This is correct for a fresh reseted database.
But if you checkout any item then prove t/db_dependent/Items.t it will
fail.
We can see in this file that other tests use filter on generated
branchcode.

This patch adds filter to items.homebranch

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Fridolin Somers 2022-03-24 14:11:57 -10:00
parent 216bb783e0
commit 29e1681ff1
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
t/db_dependent/Items.t
View file

@ -636,9 +636,19 @@ subtest 'SearchItems test' => sub {
AddIssue( $patron_borrower, $item1->barcode );
# Search item where item is checked out
$filter = {
field => 'onloan',
query => 'not null',
operator => 'is',
conjunction => 'AND',
filters => [
{
field => 'onloan',
query => 'not null',
operator => 'is',
},
{
field => 'homebranch',
query => $item1->homebranch,
operator => '=',
},
],
};
($items, $total_results) = SearchItems($filter);
ok(scalar @$items == 1, 'found 1 checked out item');
@ -648,7 +658,12 @@ subtest 'SearchItems test' => sub {
sortby => 'availability',
sortorder => 'DESC',
};
($items, $total_results) = SearchItems(undef,$params);
$filter = {
field => 'homebranch',
query => $item1->homebranch,
operator => '=',
};
($items, $total_results) = SearchItems($filter,$params);
is($items->[0]->{barcode}, $item1->barcode, 'Items sorted as expected by availability');
$schema->storage->txn_rollback;