Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 29575: (QA follow-up) Patron fields can be empty strings

Browse source 
We need to account for empty strings as well as 'null' values in the
patron data structure.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Martin Renvoize 2021-11-25 12:33:34 +00:00 committed by Fridolin Somers
parent 0d35f38466
commit 29e3d3d7fe
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc
View file

@ -15,7 +15,7 @@
}
var title = null;
if ( patron.title != null ) {
if ( patron.title != null && patron.title != '' ) {
title = '<span class="patron-title">' + escape_str(patron.title) + '</span>';
}
@ -23,7 +23,7 @@
var firstname = escape_str(patron.firstname);
var surname = escape_str(patron.surname);
if ( patron.other_name != null ) {
if ( patron.other_name != null && patron.other_name != '' ) {
firstname += ' (' + escape_str(patron.other_name) + ')';
}
if ( config && config.invert_name ) {