Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity

Bug 13601: get rid of DateTime::Format::DateParse

Browse source 
This module is used in C4::Members::GetPendingIssues too, but we can use
dt_from_string.

Test plan:
1/ Verify that
    prove t/db_dependent/Members/GetPendingIssues.t
returns green
2/ On the patron pending issue list, verify that the issue and the due
dates are correctly displayed.

Tested together with other patches (except "Fix special cases). Worked as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Jonathan Druart 2015-01-20 15:32:45 +01:00 committed by Tomas Cohen Arazi
parent c23abea835
commit 29f3218c52
2 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
C4/Installer/PerlDependencies.pm
View file

@ -222,11 +222,6 @@ our $PERL_DEPS = {
'required' => '1',
'min_ver' => '1.20'
},
'DateTime::Format::DateParse' => {
'usage' => 'Core',
'required' => '1',
'min_ver' => '0.04'
},
'DateTime::Format::MySQL' => {
'usage' => 'Core',
'required' => '1',

6
C4/Members.pm
View file

@ -36,7 +36,6 @@ use C4::SQLHelper qw(InsertInTable UpdateInTable SearchInTable);
use C4::Members::Attributes qw(SearchIdMatchingAttribute UpdateBorrowerAttribute);
use C4::NewsChannels; #get slip news
use DateTime;
use DateTime::Format::DateParse;
use Koha::Database;
use Koha::DateUtils;
use Koha::Borrower::Debarments qw(IsDebarred);
@ -1195,14 +1194,13 @@ sub GetPendingIssues {
my $sth = C4::Context->dbh->prepare($query);
$sth->execute(@borrowernumbers);
my $data = $sth->fetchall_arrayref({});
my $tz = C4::Context->tz();
my $today = DateTime->now( time_zone => $tz);
my $today = dt_from_string;
foreach (@{$data}) {
if ($_->{issuedate}) {
$_->{issuedate} = dt_from_string($_->{issuedate}, 'sql');
}
$_->{date_due} or next;
$_->{date_due} = DateTime::Format::DateParse->parse_datetime($_->{date_due}, $tz->name());
$_->{date_due} = dt_from_string($_->{date_due}, 'sql');
if ( DateTime->compare($_->{date_due}, $today) == -1 ) {
$_->{overdue} = 1;
}