Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0
We aren't actually doing any error handling with the RequireJS waitSeconds config, just leaving the advanced editor hanging on loading if it times out, so instead we should disable it. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Load the Cataloging module home page in Firefox and open Firefox's Web Developer Tools, and in the Network tab change from "No Throttling" to "Regular 2G" 3. In the Cataloging page, click Advanced editor, and watch it attempt to load for 30 seconds, followed by a setTimout error in the devtools console, and then wait as long as you can stand for anything but the "Loading, please wait..." to happen in the web page. Nothing ever will. 4. Apply the patch, restart, set EnableAdvancedCatalogingEditor back to Enable, turn throttling on, load the Advanced editor again, and note that even though it will take a minute or more to load through the throttling, the editor does actually load. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> (cherry picked from commit95394217f0
) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> (cherry picked from commitc305b46821
) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
parent
8875788379
commit
2a23a3320f
1 changed files with 1 additions and 1 deletions
|
@ -29,7 +29,7 @@ require.config( {
|
|||
themelang: '[% themelang | html %]',
|
||||
},
|
||||
},
|
||||
waitSeconds: 30,
|
||||
waitSeconds: 0,
|
||||
} );
|
||||
</script>
|
||||
|
||||
|
|
Loading…
Reference in a new issue